linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* The jbd_GFP_NORFAIL patch caused the jbd_kmalloc_kzalloc.patch fail
@ 2007-09-24 14:14 Theodore Ts'o
  0 siblings, 0 replies; only message in thread
From: Theodore Ts'o @ 2007-09-24 14:14 UTC (permalink / raw)
  To: linux-ext4


While putting together 2.6.23-rc7-ext4-1 patchset, I noticed that the
jbd_GFP_NOFAIL patch caused a patch conflict with the kmalloc/kzalloc
patch.  I also fixed up the patch comments to make the git log look
prettier. 

						- Ted


    Fix up jbd k[mz]alloc patch so it applies and fix up GFP_NOFAIL comments

diff --git a/jbd_GFP_NOFAIL_flag_cleanup.patch b/jbd_GFP_NOFAIL_flag_cleanup.patch
index 8dec157..da02815 100644
--- a/jbd_GFP_NOFAIL_flag_cleanup.patch
+++ b/jbd_GFP_NOFAIL_flag_cleanup.patch
@@ -1,3 +1,8 @@
+jbd/jbd2: Journal initialization doesn't need __GFP_NOFAIL
+
+Signed-off-by: Mingming Cao <cmm@us.ibm.com>
+Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
+
 ---
  fs/jbd/journal.c  |    2 +-
  fs/jbd2/journal.c |    2 +-
diff --git a/jbd_kmalloc_kzalloc.patch b/jbd_kmalloc_kzalloc.patch
index a426d0e..8ca0469 100644
--- a/jbd_kmalloc_kzalloc.patch
+++ b/jbd_kmalloc_kzalloc.patch
@@ -22,7 +22,7 @@ Index: linux-2.6.23-rc6/fs/jbd/journal.c
  	journal_t *journal;
  	int err;
  
--	journal = kmalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
+-	journal = kmalloc(sizeof(*journal), GFP_KERNEL);
 +	journal = kzalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
  	if (!journal)
  		goto fail;
@@ -51,7 +51,7 @@ Index: linux-2.6.23-rc6/fs/jbd2/journal.c
  	journal_t *journal;
  	int err;
  
--	journal = kmalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
+-	journal = kmalloc(sizeof(*journal), GFP_KERNEL);
 +	journal = kzalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
  	if (!journal)
  		goto fail;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-09-24 14:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24 14:14 The jbd_GFP_NORFAIL patch caused the jbd_kmalloc_kzalloc.patch fail Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).