From: Andreas Dilger <adilger@dilger.ca>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: inplace xattr block update fails to deduplicate blocks
Date: Sat, 15 Jul 2017 02:49:05 -0700 [thread overview]
Message-ID: <EAEB944F-E38E-41CE-ACE6-AC9BE0E28598@dilger.ca> (raw)
In-Reply-To: <20170715002529.31045-1-tahsin@google.com>
[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]
On Jul 14, 2017, at 5:25 PM, Tahsin Erdogan <tahsin@google.com> wrote:
>
> When an xattr block has a single reference, block is updated inplace
> and it is reinserted to the cache. Later, a cache lookup is performed
> to see whether an existing block has the same contents. This cache
> lookup will most of the time return the just inserted entry so
> deduplication is not achieved.
>
> Running the following test script will produce two xattr blocks which
> can be observed in "File ACL: " line of debugfs output:
>
> mke2fs -b 1024 -I 128 -F -O extent /dev/sdb 1G
> mount /dev/sdb /mnt/sdb
>
> touch /mnt/sdb/{x,y}
>
> setfattr -n user.1 -v aaa /mnt/sdb/x
> setfattr -n user.2 -v bbb /mnt/sdb/x
>
> setfattr -n user.1 -v aaa /mnt/sdb/y
> setfattr -n user.2 -v bbb /mnt/sdb/y
>
> debugfs -R 'stat x' /dev/sdb | cat
> debugfs -R 'stat y' /dev/sdb | cat
>
> This patch defers the reinsertion to the cache so that we can locate
> other blocks with the same contents.
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/xattr.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index cff4f41ced61..ad4ea1cf685f 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1815,9 +1815,6 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
> ea_bdebug(bs->bh, "modifying in-place");
> error = ext4_xattr_set_entry(i, s, handle, inode,
> true /* is_block */);
> - if (!error)
> - ext4_xattr_block_cache_insert(ea_block_cache,
> - bs->bh);
> ext4_xattr_block_csum_set(inode, bs->bh);
> unlock_buffer(bs->bh);
> if (error == -EFSCORRUPTED)
> @@ -1973,6 +1970,7 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
> } else if (bs->bh && s->base == bs->bh->b_data) {
> /* We were modifying this block in-place. */
> ea_bdebug(bs->bh, "keeping this block");
> + ext4_xattr_block_cache_insert(ea_block_cache, bs->bh);
> new_bh = bs->bh;
> get_bh(new_bh);
> } else {
> --
> 2.13.2.932.g7449e964c-goog
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-07-15 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 0:25 [PATCH] ext4: inplace xattr block update fails to deduplicate blocks Tahsin Erdogan
2017-07-15 9:49 ` Andreas Dilger [this message]
2017-08-06 2:50 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAEB944F-E38E-41CE-ACE6-AC9BE0E28598@dilger.ca \
--to=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tahsin@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox