From: Andreas Dilger <adilger@dilger.ca>
To: JP Abgrall <jpa@google.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-ext4@vger.kernel.org,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Geremy Condra <gcondra@google.com>
Subject: Re: [PATCH] ext4: Add support for FIDTRIM, a best-effort ioctl for deep discard trim
Date: Thu, 24 Jul 2014 21:46:38 -0600 [thread overview]
Message-ID: <EFCA683A-25F1-4A58-9500-42E2FD044656@dilger.ca> (raw)
In-Reply-To: <CAKP4w2TzDu6d=hK+21GnZU6Sd_gH8icJ=XA3q23Oa9Bd9fF6uA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Jul 24, 2014, at 7:50 PM, JP Abgrall <jpa@google.com> wrote:
> On Thu, Jul 24, 2014 at 5:08 AM, Dave Chinner <david@fromorbit.com> wrote:
>>
>> On Wed, Jul 23, 2014 at 04:47:18PM -0700, JP Abgrall wrote:
>>> +#define FIDTRIM _IOWR('X', 122, struct fstrim_range) /* Deep discard trim */
>>
>> The 'X' ioctl namespace is actually XFS's ioctl namespace. FIDTRIM
>> should be in the 'f' namespace
>
> Ok.
> How should the next sequence number be handled?
> Go with ('f', 122,...) after FITRIM, or go with ('f', 12,...) after
> FS_IOC_FIEMAP ('f' namepsace)?
Please leave the low 'f' values for ext2/3/4 (where FS_IOC_[GS]ETFLAGS,
FS_IOC_[GS]ETFLAGS, and FS_IOC_FIEMAPand came from, and use high 'f'
numbers, maybe starting at 128 (?) for generic ioctl values.
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2014-07-25 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 23:47 [PATCH] ext4: Add support for FIDTRIM, a best-effort ioctl for deep discard trim JP Abgrall
2014-07-24 12:08 ` Dave Chinner
2014-07-25 1:50 ` JP Abgrall
2014-07-25 3:46 ` Andreas Dilger [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-29 22:58 JP Abgrall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EFCA683A-25F1-4A58-9500-42E2FD044656@dilger.ca \
--to=adilger@dilger.ca \
--cc=david@fromorbit.com \
--cc=gcondra@google.com \
--cc=jpa@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox