linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@dilger.ca>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 1/4] mke2fs: document the hash_seed option
Date: Sat, 20 Sep 2025 12:52:38 -0600	[thread overview]
Message-ID: <F29BC06C-B943-4D2A-ACDB-2DE9FC015280@dilger.ca> (raw)
In-Reply-To: <20250910-mke2fs-small-fixes-v2-1-55c9842494e0@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

On Sep 10, 2025, at 7:51 AM, Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
> 
> For reproducible builds, it is necessary to control the random seed used
> for hashing. Document the extended option for this feature.
> 
> Fixes: e1f71006 ("AOSP: mke2fs, libext2fs: make filesystem image reproducible")
> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> misc/mke2fs.8.in | 4 ++++
> misc/mke2fs.c    | 1 +
> 2 files changed, 5 insertions(+)
> 
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index 13ddef47..14bae326 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -320,6 +320,10 @@ In the default configuration, the
> .I strict
> flag is disabled.
> .TP
> +.BI hash_seed= UUID
> +Use the specified UUID as the seed for hashing, rather than generating a
> +random seed each time. Intended for use with reproducible builds.
> +.TP
> .B lazy_itable_init\fR[\fB= \fI<0 to disable, 1 to enable>\fR]
> If enabled and the uninit_bg feature is enabled, the inode table will
> not be fully initialized by
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 7f81a513..3a8ff5b1 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1180,6 +1180,7 @@ static void parse_extended_opts(struct ext2_super_block *param,
> 			"\trevision=<revision>\n"
> 			"\tencoding=<encoding>\n"
> 			"\tencoding_flags=<flags>\n"
> +			"\thash_seed=<UUID for hash seed>\n"
> 			"\tquotatype=<quota type(s) to be enabled>\n"
> 			"\tassume_storage_prezeroed=<0 to disable, 1 to enable>\n\n"),
> 			badopt ? badopt : "");
> 
> --
> 2.45.2.121.gc2b3f2b3cd
> 
> 


Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]

  reply	other threads:[~2025-09-20 18:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 13:51 [PATCH v2 0/4] mke2fs: small doc and features Ralph Siemsen
2025-09-10 13:51 ` [PATCH v2 1/4] mke2fs: document the hash_seed option Ralph Siemsen
2025-09-20 18:52   ` Andreas Dilger [this message]
2025-09-10 13:51 ` [PATCH v2 2/4] mke2fs: support multiple '-E' options Ralph Siemsen
2025-09-20 18:53   ` Andreas Dilger
2025-09-10 13:51 ` [PATCH v2 3/4] mke2fs: add root_selinux option for root inode label Ralph Siemsen
2025-09-20 22:39   ` Andreas Dilger
2025-09-22 14:31     ` Ralph Siemsen
2025-09-10 13:51 ` [PATCH v2 4/4] mke2fs: fix missing .TP in man page Ralph Siemsen
2025-09-20 22:59   ` Andreas Dilger
2025-09-22 14:46     ` Ralph Siemsen
2025-11-11 20:09 ` [PATCH v2 0/4] mke2fs: small doc and features Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F29BC06C-B943-4D2A-ACDB-2DE9FC015280@dilger.ca \
    --to=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ralph.siemsen@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).