Re: [Resubmit][PATCH 5/5] Secure Deletion and Trash-Bin Support for Ext4

[Nikolai Joukov <kolya@cs.sunysb.edu>]

> Right now I've only really looked at the jfs patch, since that's what
> I'm the most familiar with.  I'll try to take a look at the rest of them
> later.

Thank you!

> I don't have a strong opinion for or against the function and your
> design.  The only potential problem I see in the approach is that
> the .trash directory may conflict with some other use of the same name.
> Since this is primarily vfs function, you'll probably get a wider
> audience on linux-fsdevel.

Well, I guess lost+found has the same problem but it is not a problem at
all to pick some other (longer) name.

> Have you considered putting ALL of the function in the vfs layer?  It
> looks like this could be done without touching any code in the
> individual file systems.

Unfortunately, we need some file system-specific code to access per-file
secure deletion and per-file trash bit attributes.  These attributes are
supported only by some file systems and in different ways.  We need no
file system-specific code to support trash-bin deletion for whole file
systems.

Nikolai.