From: Christoph Lameter <clameter@sgi.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com
Subject: Re: [RFC/PATCH] ext3: remove inode constructor
Date: Fri, 4 May 2007 09:08:25 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0705040907180.21436@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705041311230.1455@sbz-30.cs.Helsinki.FI>
On Fri, 4 May 2007, Pekka J Enberg wrote:
> Index: 2.6/fs/ext3/super.c
> ===================================================================
> --- 2.6.orig/fs/ext3/super.c 2007-05-04 12:57:09.000000000 +0300
> +++ 2.6/fs/ext3/super.c 2007-05-04 13:01:27.000000000 +0300
> @@ -444,17 +444,26 @@ static struct kmem_cache *ext3_inode_cac
> static struct inode *ext3_alloc_inode(struct super_block *sb)
> {
> struct ext3_inode_info *ei;
> + struct inode *inode;
>
> ei = kmem_cache_alloc(ext3_inode_cachep, GFP_NOFS);
> if (!ei)
> return NULL;
> + INIT_LIST_HEAD(&ei->i_orphan);
> +#ifdef CONFIG_EXT3_FS_XATTR
> + init_rwsem(&ei->xattr_sem);
> +#endif
> + mutex_init(&ei->truncate_mutex);
^^^ whitespace issues
Also could this be generalized to also apply to the generic inode
allocation in fs/inode.c?
next prev parent reply other threads:[~2007-05-04 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 10:14 [RFC/PATCH] ext3: remove inode constructor Pekka J Enberg
2007-05-04 16:08 ` Christoph Lameter [this message]
2007-05-05 9:21 ` Pekka J Enberg
2007-05-04 20:02 ` Andrew Morton
2007-05-05 8:58 ` Pekka J Enberg
2007-05-05 9:02 ` Andrew Morton
2007-05-05 9:08 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705040907180.21436@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).