From: "Theodore Ts'o" <tytso@mit.edu>
To: yangerkun <yangerkun@huawei.com>
Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
jack@suse.cz, yi.zhang@huawei.com, lihaotian9@huawei.com,
lutianxiong@huawei.com, linfeilong@huawei.com
Subject: Re: [PATCH v2] ext4: fix bug for rename with RENAME_WHITEOUT
Date: Tue, 29 Dec 2020 17:24:06 -0500 [thread overview]
Message-ID: <X+ushgURuSXY4Lz9@mit.edu> (raw)
In-Reply-To: <20201229090208.1113218-1-yangerkun@huawei.com>
On Tue, Dec 29, 2020 at 05:02:08PM +0800, yangerkun wrote:
> ext4_rename will create a special inode for whiteout and use this 'ino'
> to replace the source file's dir entry 'ino'. Once error happens
> latter(small ext4 img, and consume all space, so the rename with dst
> path not exist will fail due to the ENOSPC return from ext4_add_entry in
> ext4_rename), the cleanup do drop the nlink for whiteout, but forget to
> restore 'ino' with source file. This will lead to "deleted inode
> referenced".
Could you sendhave instructions how to reproduce this failure? Many thanks!!
- Ted
next prev parent reply other threads:[~2020-12-29 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 9:02 [PATCH v2] ext4: fix bug for rename with RENAME_WHITEOUT yangerkun
2020-12-29 22:24 ` Theodore Ts'o [this message]
2020-12-30 3:29 ` yangerkun
2021-01-04 14:19 ` Jan Kara
2021-01-05 5:58 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+ushgURuSXY4Lz9@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=lihaotian9@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=lutianxiong@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox