From: "Theodore Ts'o" <tytso@mit.edu>
To: zhanchengbin <zhanchengbin1@huawei.com>
Cc: linux-ext4@vger.kernel.org, linfeilong@huawei.com,
louhongxiang@huawei.com
Subject: Re: [PATCH v2] lib/ext2fs: add some msg for io error
Date: Thu, 23 Feb 2023 22:47:05 -0500 [thread overview]
Message-ID: <Y/gzOSmW70rXcjvq@mit.edu> (raw)
In-Reply-To: <20230223090111.680573-1-zhanchengbin1@huawei.com>
On Thu, Feb 23, 2023 at 05:01:11PM +0800, zhanchengbin wrote:
> Add msgs to show whether there is eio in fsck process, when write and
> fsync methods fail.
>
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
The libext2fs is a *library*. As such, well designed libraries do not
randomly write to stderr. Consider what might happen if there was a
curses based program that was calling libext2fs --- for example, like
the ext2ed program. Writing random errors to stderr is just *rude*. :-)
If what you're worried about errors from e2fsck, it's also not
necessary, since that's what the error handler callback is for.
Cheers,
- Ted
next prev parent reply other threads:[~2023-02-24 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 9:01 [PATCH v2] lib/ext2fs: add some msg for io error zhanchengbin
2023-02-24 3:47 ` Theodore Ts'o [this message]
2023-02-24 7:38 ` zhanchengbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/gzOSmW70rXcjvq@mit.edu \
--to=tytso@mit.edu \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=zhanchengbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).