From: Eric Biggers <ebiggers@kernel.org>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org
Subject: Re: [e2fsprogs PATCH] e2fsck: don't allow journal inode to have encrypt flag
Date: Wed, 2 Nov 2022 15:07:15 -0700 [thread overview]
Message-ID: <Y2LqExmYPBIOypW0@sol.localdomain> (raw)
In-Reply-To: <B8D39676-D175-4AC9-B74B-95D4AAF03A9A@dilger.ca>
On Wed, Nov 02, 2022 at 02:55:05PM -0600, Andreas Dilger wrote:
> On Nov 1, 2022, at 11:35 PM, Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Since the kernel is being fixed to consider journal inodes with the
> > 'encrypt' flag set to be invalid, also update e2fsck accordingly.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> > e2fsck/journal.c | 3 ++-
> > tests/f_badjour_encrypted/expect.1 | 30 +++++++++++++++++++++++++++++
> > tests/f_badjour_encrypted/expect.2 | 7 +++++++
> > tests/f_badjour_encrypted/image.gz | Bin 0 -> 2637 bytes
>
> Good to have a test case for this.
>
> In the past Ted has asked that new test cases are generated via mke2fs
> and debugfs in "f_XXX/script" file rather than a binary image, if possible.
I didn't realize the test suite supported this. Done in v2, thanks!
- Eric
prev parent reply other threads:[~2022-11-02 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 5:35 [e2fsprogs PATCH] e2fsck: don't allow journal inode to have encrypt flag Eric Biggers
2022-11-02 20:55 ` Andreas Dilger
2022-11-02 22:07 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2LqExmYPBIOypW0@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox