From: Eric Biggers <ebiggers@kernel.org>
To: JunChao Sun <sunjunchao2870@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu,
adilger.kernel@dilger.ca, jack@suse.cz
Subject: Re: [PATCH] ext4: replace kmem_cache_create with KMEM_CACHE
Date: Wed, 9 Nov 2022 10:00:19 -0800 [thread overview]
Message-ID: <Y2vqs7/Djy22B6XE@sol.localdomain> (raw)
In-Reply-To: <20221109153822.80250-1-sunjunchao2870@gmail.com>
On Wed, Nov 09, 2022 at 07:38:22AM -0800, JunChao Sun wrote:
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index 3d21eae267fc..773176e7f9f5 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -410,9 +410,8 @@ int ext4_mpage_readpages(struct inode *inode,
>
> int __init ext4_init_post_read_processing(void)
> {
> - bio_post_read_ctx_cache =
> - kmem_cache_create("ext4_bio_post_read_ctx",
> - sizeof(struct bio_post_read_ctx), 0, 0, NULL);
> + bio_post_read_ctx_cache = KMEM_CACHE(bio_post_read_ctx, SLAB_RECLAIM_ACCOUNT);
> +
Why use SLAB_RECLAIM_ACCOUNT here?
- Eric
next prev parent reply other threads:[~2022-11-09 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 15:38 [PATCH] ext4: replace kmem_cache_create with KMEM_CACHE JunChao Sun
2022-11-09 15:49 ` Jan Kara
2022-11-09 18:00 ` Eric Biggers [this message]
2022-11-10 0:53 ` JunChao Sun
2022-11-10 2:47 ` Eric Biggers
2022-11-10 3:44 ` JunChao Sun
2022-11-11 23:42 ` JunChao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2vqs7/Djy22B6XE@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sunjunchao2870@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox