Re: [PATCH 3/9] ext4: Remove nr_submitted from ext4_bio_write_page()

Ritesh Harjani (IBM)
2022-12-01T09:14:50Z

On 22/11/30 05:35PM, Jan Kara wrote:
> nr_submitted is the same as nr_to_submit. Drop one of them.

Yup. Since we are not calling end_page_writeback() anymore.
So we don't require nr_submitted too.

Looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ext4/page-io.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
> index 4f9ecacd10aa..2bdfb8a046d9 100644
> --- a/fs/ext4/page-io.c
> +++ b/fs/ext4/page-io.c
> @@ -437,7 +437,6 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
> unsigned block_start;
> struct buffer_head *bh, *head;
> int ret = 0;
> - int nr_submitted = 0;
> int nr_to_submit = 0;
> struct writeback_control *wbc = io->io_wbc;
> bool keep_towrite = false;
> @@ -566,7 +565,6 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
> continue;
> io_submit_add_bh(io, inode,
> bounce_page ? bounce_page : page, bh);
> - nr_submitted++;
> } while ((bh = bh->b_this_page) != head);
> unlock:
> unlock_page(page);
> --
> 2.35.3
>