From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 362C0C352A1 for ; Wed, 7 Dec 2022 07:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbiLGHiz (ORCPT ); Wed, 7 Dec 2022 02:38:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiLGHiy (ORCPT ); Wed, 7 Dec 2022 02:38:54 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7297D338 for ; Tue, 6 Dec 2022 23:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A/eq4/wgg2rp1ld2NuQJrWGKee0voE45fREibRm9FUw=; b=23zWkMQ0yZoj9k5q6yInfok+g/ +eKXpmTUpvK26qhTXssR43JuDx5KaBiJ6Y4NTXmY0HQa+kg67H8C0xsxE1u4sQMzSHTqFEW/Ys8P/ mFDKrC3SkxdtAyZwE/oQoTtumJn8SoMniscm4Xvvf2UTgV1L5+ni7CrYAdfWDSFm93XJOUyJ49fm+ l2LQghB/ezZ/5gYC/0duKvJgq957XVDuc32bqlprarj5Zujk5O4sjl9LIA4NN3Op74jMqD09eOwhG UpSDAxvwZ3q8NeZ+Gq8/BEgYWysrMfu3UYmrtXwBZHV/ZAwmYNcpVnSj/XX8Rgo3eJtoQT47fCVfX d8G/iZfA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2p10-00E760-PT; Wed, 07 Dec 2022 07:38:50 +0000 Date: Tue, 6 Dec 2022 23:38:50 -0800 From: Christoph Hellwig To: Jan Kara Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Christoph Hellwig , "Ritesh Harjani (IBM)" , Christoph Hellwig , Matthew Wilcox , linux-mm@kvack.org Subject: Re: [PATCH v3 11/12] ext4: Stop providing .writepage hook Message-ID: References: <20221205122604.25994-1-jack@suse.cz> <20221205122928.21959-11-jack@suse.cz> <20221206105225.nr734teqlkueqdph@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206105225.nr734teqlkueqdph@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Dec 06, 2022 at 11:52:25AM +0100, Jan Kara wrote: > I don't expect any objection. The only reason we didn't export that > function when I've added it was that only blkdev code was using it and that > cannot be compiled as a module. Should I send a patch to > > I've added a patch to the series to export this function. It is attached. > > I can also repost the whole series if these are the only changes that block > the inclusion. I'd do an EXPORT_SYMBOL_GPL, but otherwise the export looks fine, and it would be good to get this conversion going!