From: "Theodore Ts'o" <tytso@mit.edu>
To: Li Jinlin <lijinlin3@huawei.com>
Cc: linux-ext4@vger.kernel.org,
Zhiqiang Liu <liuzhiqiang26@huawei.com>,
linfeilong@huawei.com
Subject: Re: [PATCH] e2fsck: subtract acl blocks when setting i_file_acl to zero
Date: Wed, 18 Jan 2023 00:53:13 -0500 [thread overview]
Message-ID: <Y8eJSWwlyaVjgY/2@mit.edu> (raw)
In-Reply-To: <8e8f277d-6222-5f63-0dcb-a17771a0deff@huawei.com>
This patch is not correct. We don't need to create a new
ext2fs_adjust_ea_refcount4 to return the h_blocks field in the
extended attribute block, since that only thing that we support is a
single xattr block.
The real issue, as Zhiqiang Liu pointed out in [1], is that we should
not be clearing the i_file_acl block is the inode is only being
truncated, and not being unlinked.
[1] https://lore.kernel.org/all/ed518b11-3c38-1c1f-a75d-3293c91f17d4@huawei.com/
- Ted
prev parent reply other threads:[~2023-01-18 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220317172943.2426272-1-lijinlin3@huawei.com>
2022-03-17 16:54 ` [PATCH] e2fsck: subtract acl blocks when setting i_file_acl to zero Li Jinlin
2022-03-21 1:59 ` Zhiqiang Liu
2023-01-18 5:53 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8eJSWwlyaVjgY/2@mit.edu \
--to=tytso@mit.edu \
--cc=lijinlin3@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).