From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521F4C6379F for ; Wed, 18 Jan 2023 16:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbjARQuQ (ORCPT ); Wed, 18 Jan 2023 11:50:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjARQuP (ORCPT ); Wed, 18 Jan 2023 11:50:15 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A6CE38015 for ; Wed, 18 Jan 2023 08:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674060567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lgwAP3iZLubX4jJpj4ZhHlVnjkE2V1abu7VwSCjHn5c=; b=FpPtyau+an4M+Xmird4Xa55nXKWQRW/HNcmcQSdNAXfbf6uBNlSZv3LT2A3ZKvHicboUzb 5ELS9ts1FsvaSwHadjEFvZqjjYegwwWO8LSgtzewRICSYz2nb+oU85GmlxeCh6ixDlgHGz THvX5plULwo/UDZKgbfGkNtQcVQ4LXM= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-101-OoIO0oIeNdG4tu0_7wWiqg-1; Wed, 18 Jan 2023 11:49:25 -0500 X-MC-Unique: OoIO0oIeNdG4tu0_7wWiqg-1 Received: by mail-ua1-f72.google.com with SMTP id o43-20020ab0596e000000b0038421e4c7deso13974861uad.19 for ; Wed, 18 Jan 2023 08:49:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lgwAP3iZLubX4jJpj4ZhHlVnjkE2V1abu7VwSCjHn5c=; b=hjUz0NNTU6E6LrdaqkXgghCXXByVlPimTRD25sxNP9IshFwD4Na1oY4v7rveRsO+zJ XeSWjgguwmNG4rKN4QcLh9RHpEGwiYy4Sp4qSv7ehrZPXnp9K1YtC/aS+T1ZhZp8a74/ B/WY1tqsf0R6IMrcc1Qyce2Rnjt1s/wyqTvNdQ/2/eOocD37AeyAbxD9L4zPRROZ9qhv Fnc/0Cw5ds6So0ubb0blnCFZx3hS0gRKA2r2Q4/wgEte4KGjF3ZTqBhR2IUcqT8aG58+ ptOqxLWrAmViw5AR4Eitt7RINWJA/6Nx2Dd27bXUB2676H4pfvuWeEIKhuMKo1CVQtuh +ePQ== X-Gm-Message-State: AFqh2krC50o5fuXtKzS2wJU9f87CFvIxTYiYs87/WuisETijGgbnfo75 VmbIPG8IODVseLZP7rHcwimQdUw0wihN+Vs7k6fL7s/GAn/d77sooVfcKfeBOF0dK86+KQGg75E +xi+un2U6YglY5EBwHS5/FA== X-Received: by 2002:a05:6122:c54:b0:3d5:5366:dc6c with SMTP id i20-20020a0561220c5400b003d55366dc6cmr4414363vkr.4.1674060565083; Wed, 18 Jan 2023 08:49:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXvRoSYdOHAFhWX6SkAWaiD3PJ9bgCoG4JU7ThLaby5WFm6CrHkvSID8k/76bqXjrAWdFrKBiQ== X-Received: by 2002:a05:6122:c54:b0:3d5:5366:dc6c with SMTP id i20-20020a0561220c5400b003d55366dc6cmr4414340vkr.4.1674060564852; Wed, 18 Jan 2023 08:49:24 -0800 (PST) Received: from bfoster (c-24-61-119-116.hsd1.ma.comcast.net. [24.61.119.116]) by smtp.gmail.com with ESMTPSA id dt26-20020a05620a479a00b00705c8cce5dcsm11812650qkb.111.2023.01.18.08.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 08:49:24 -0800 (PST) Date: Wed, 18 Jan 2023 11:50:26 -0500 From: Brian Foster To: Christoph Hellwig Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 4/9] shmem: remove shmem_get_partial_folio Message-ID: References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-5-hch@lst.de> <20230118164358.GD7584@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118164358.GD7584@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 18, 2023 at 05:43:58PM +0100, Christoph Hellwig wrote: > On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote: > > This all seems reasonable to me at a glance, FWIW, but I am a little > > curious why this wouldn't split up into two changes. I.e., switch this > > over to filemap_get_entry() to minimally remove the FGP_ENTRY dependency > > without a behavior change, then (perhaps after the next patch) introduce > > SGP_FIND in a separate patch. That makes it easier to review and > > potentially undo if it happens to pose a problem in the future. Hm? > > The minimal change to filemap_get_entry would require to add the > lock, check mapping and retry loop and thus add a fair amount of > code. So I looked for ways to avoid that and came up with this > version. But if there is a strong preference to first open code > the logic and then later consolidate it I could do that. > Ok. Not a strong preference from me. I don't think it's worth complicating that much just to split up. Brian