From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A32C4332D for ; Thu, 21 Jan 2021 16:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB60A23A3C for ; Thu, 21 Jan 2021 16:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388057AbhAUQuO (ORCPT ); Thu, 21 Jan 2021 11:50:14 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58766 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728156AbhAUP6I (ORCPT ); Thu, 21 Jan 2021 10:58:08 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10LFuYo9003734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 10:56:35 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 63C8C15C35F5; Thu, 21 Jan 2021 10:56:34 -0500 (EST) Date: Thu, 21 Jan 2021 10:56:34 -0500 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH v3 04/15] libext2fs: provide APIs to configure fast commit blocks Message-ID: References: <20210120212641.526556-1-user@harshads-520.kir.corp.google.com> <20210120212641.526556-5-user@harshads-520.kir.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120212641.526556-5-user@harshads-520.kir.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 20, 2021 at 01:26:30PM -0800, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > This patch adds new libext2fs that allow configuring number of fast > commit blocks in journal superblock. We also add a struct > ext2fs_journal_params which contains number of fast commit blocks and > number of normal journal blocks. With this patch, the preferred way > for configuring number of blocks with and without fast commits is: > > struct ext2fs_journal_params params; > > ext2fs_get_journal_params(¶ms, ...); > params.num_journal_blocks = ...; > params.num_fc_blocks = ...; > ext2fs_create_journal_superblock2(..., ¶ms, ...); > OR > ext2fs_add_journal_inode3(..., ¶ms, ...); > > Signed-off-by: Harshad Shirwadkar I've applied to the next branch a modified version of this which is based on the Dec. 20th version of this change, with a local static inline copy of jbd2_journal_get_num_fc_blks() in ljs.c, as I had mentioned earlier. - Ted