* [PATCH e2fsprogs] build: Add SYSLIBS to e4crypt linking
@ 2020-12-15 23:05 Hauke Mehrtens
2021-01-21 23:25 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2020-12-15 23:05 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Hauke Mehrtens
The $(SYSLIBS) was missing when linking the e4crypt application. This is
available in the e4crypt.profiled variant, so I assume this was just
missing in the normal variant and is not left out intentionally.
This fixes building e2fsprogrs with -fsanitize=undefined in the global
CFLAGS nad LDFLAGS.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
misc/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/Makefile.in b/misc/Makefile.in
index fde01775..ae1fc42e 100644
--- a/misc/Makefile.in
+++ b/misc/Makefile.in
@@ -248,7 +248,7 @@ e4defrag: $(E4DEFRAG_OBJS) $(DEPLIBS)
e4crypt: $(E4CRYPT_OBJS) $(DEPLIBS) $(DEPSTATIC_LIBUUID)
$(E) " LD $@"
$(Q) $(CC) $(ALL_LDFLAGS) -o e4crypt $(E4CRYPT_OBJS) \
- $(LIBUUID) $(LIBS)
+ $(LIBUUID) $(LIBS) $(SYSLIBS)
e4defrag.profiled: $(E4DEFRAG_OBJS) $(PROFILED_DEPLIBS)
$(E) " LD $@"
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH e2fsprogs] build: Add SYSLIBS to e4crypt linking
2020-12-15 23:05 [PATCH e2fsprogs] build: Add SYSLIBS to e4crypt linking Hauke Mehrtens
@ 2021-01-21 23:25 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2021-01-21 23:25 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: linux-ext4
On Wed, Dec 16, 2020 at 12:05:57AM +0100, Hauke Mehrtens wrote:
> The $(SYSLIBS) was missing when linking the e4crypt application. This is
> available in the e4crypt.profiled variant, so I assume this was just
> missing in the normal variant and is not left out intentionally.
Thanks, I've applied. It was left out unintentionally, although I
don't see how this is affecting building e2fsprogs with
-fsanitize=undefined in the global CFLAGS and LDFLAGS. (Which worked
for me both before and after applying this change.)
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-21 23:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-15 23:05 [PATCH e2fsprogs] build: Add SYSLIBS to e4crypt linking Hauke Mehrtens
2021-01-21 23:25 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).