From: "Theodore Ts'o" <tytso@mit.edu>
To: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Cc: linux-ext4@vger.kernel.org, drosen@google.com,
krisman@collabora.com, ebiggers@kernel.org
Subject: Re: [PATCH v3 12/12] tests: f_bad_fname: Test fixes of invalid filenames and duplicates
Date: Wed, 27 Jan 2021 23:08:58 -0500 [thread overview]
Message-ID: <YBI42sG2VcE25h4h@mit.edu> (raw)
In-Reply-To: <20201217173544.52953-13-arnaud.ferraris@collabora.com>
On Thu, Dec 17, 2020 at 06:35:44PM +0100, Arnaud Ferraris wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
It looks like you didn't regenerate the expect.1 file after changing
the problem description.
% cat f_bad_fname.failed
--- /usr/projects/e2fsprogs/e2fsprogs/tests/f_bad_fname/expect.1 2021-01-28 03:20:36.813595045 +0000
+++ f_bad_fname.1.log 2021-01-28 03:25:49.940137813 +0000
@@ -1,9 +1,9 @@
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
-Entry 'AM-^?' in /ci_dir (12) has illegal characters in its name.
+Entry 'AM-^?' in /ci_dir (12) has illegal UTF-8 characters in its name.
Fix? yes
-Entry 'AM-~' in /ci_dir (12) has illegal characters in its name.
+Entry 'AM-~' in /ci_dir (12) has illegal UTF-8 characters in its name.
Fix? yes
Duplicate entry 'A.' found.
I'll fix this up in my tree.
- Ted
prev parent reply other threads:[~2021-01-28 4:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 17:35 [PATCH v3 00/12] e2fsprogs: improve case-insensitive fs Arnaud Ferraris
2020-12-17 17:35 ` [PATCH v3 01/12] tune2fs: Allow enabling casefold feature after fs creation Arnaud Ferraris
2021-01-28 2:58 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 02/12] tune2fs: Fix casefold+encrypt error message Arnaud Ferraris
2021-01-28 2:58 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 03/12] ext2fs: Add method to validate casefolded strings Arnaud Ferraris
2021-01-28 2:58 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 04/12] ext2fs: Implement faster CI comparison of strings Arnaud Ferraris
2021-01-28 2:59 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 05/12] e2fsck: Add new problem for encoded name check Arnaud Ferraris
2021-01-28 3:05 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 06/12] e2fsck: Fix entries with invalid encoded characters Arnaud Ferraris
2021-01-28 3:10 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 07/12] e2fsck: Support casefold directories when rehashing Arnaud Ferraris
2021-01-28 3:10 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 08/12] dict: Support comparison with context Arnaud Ferraris
2021-01-28 3:16 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 09/12] e2fsck: Detect duplicated casefolded direntries for rehash Arnaud Ferraris
2021-01-28 3:17 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 10/12] e2fsck: Add option to force encoded filename verification Arnaud Ferraris
2021-01-28 3:19 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 11/12] e2fsck.8.in: Document check_encoding extended option Arnaud Ferraris
2021-01-28 3:19 ` Theodore Ts'o
2020-12-17 17:35 ` [PATCH v3 12/12] tests: f_bad_fname: Test fixes of invalid filenames and duplicates Arnaud Ferraris
2021-01-28 4:08 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBI42sG2VcE25h4h@mit.edu \
--to=tytso@mit.edu \
--cc=arnaud.ferraris@collabora.com \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox