From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC86AC433E0 for ; Thu, 28 Jan 2021 04:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CE9B64D92 for ; Thu, 28 Jan 2021 04:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbhA1EKA (ORCPT ); Wed, 27 Jan 2021 23:10:00 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:51479 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229530AbhA1EJw (ORCPT ); Wed, 27 Jan 2021 23:09:52 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10S48xaa011177 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 23:08:59 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id C8D4C15C344F; Wed, 27 Jan 2021 23:08:58 -0500 (EST) Date: Wed, 27 Jan 2021 23:08:58 -0500 From: "Theodore Ts'o" To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, drosen@google.com, krisman@collabora.com, ebiggers@kernel.org Subject: Re: [PATCH v3 12/12] tests: f_bad_fname: Test fixes of invalid filenames and duplicates Message-ID: References: <20201217173544.52953-1-arnaud.ferraris@collabora.com> <20201217173544.52953-13-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217173544.52953-13-arnaud.ferraris@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 17, 2020 at 06:35:44PM +0100, Arnaud Ferraris wrote: > From: Gabriel Krisman Bertazi > > Signed-off-by: Gabriel Krisman Bertazi > Signed-off-by: Arnaud Ferraris It looks like you didn't regenerate the expect.1 file after changing the problem description. % cat f_bad_fname.failed --- /usr/projects/e2fsprogs/e2fsprogs/tests/f_bad_fname/expect.1 2021-01-28 03:20:36.813595045 +0000 +++ f_bad_fname.1.log 2021-01-28 03:25:49.940137813 +0000 @@ -1,9 +1,9 @@ Pass 1: Checking inodes, blocks, and sizes Pass 2: Checking directory structure -Entry 'AM-^?' in /ci_dir (12) has illegal characters in its name. +Entry 'AM-^?' in /ci_dir (12) has illegal UTF-8 characters in its name. Fix? yes -Entry 'AM-~' in /ci_dir (12) has illegal characters in its name. +Entry 'AM-~' in /ci_dir (12) has illegal UTF-8 characters in its name. Fix? yes Duplicate entry 'A.' found. I'll fix this up in my tree. - Ted