From: "Theodore Ts'o" <tytso@mit.edu>
To: Daniel Latypov <dlatypov@google.com>
Cc: brendanhiggins@google.com, davidgow@google.com,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
kunit-dev@googlegroups.com
Subject: Re: [PATCH] ext4: add .kunitconfig fragment to enable ext4-specific tests
Date: Thu, 11 Feb 2021 23:22:53 -0500 [thread overview]
Message-ID: <YCYCnaEMc95hDfso@mit.edu> (raw)
In-Reply-To: <20210210013206.136227-1-dlatypov@google.com>
On Tue, Feb 09, 2021 at 05:32:06PM -0800, Daniel Latypov wrote:
> As of [1], we no longer want EXT4_KUNIT_TESTS and others to `select`
> their deps. This means it can get harder to get all the right things
> selected as we gain more tests w/ more deps over time.
>
> This patch (and [2]) proposes we store kunitconfig fragments in-tree to
> represent sets of tests. (N.B. right now we only have one ext4 test).
>
> There's still a discussion to be had about how to have a hierarchy of
> these files (e.g. if one wanted to test all of fs/, not just fs/ext4).
>
> But this fragment would likely be a leaf node and isn't blocked on
> deciding if we want `import` statements and the like.
>
> Usage
> =====
>
> Before [2] (on its way to being merged):
> $ cp fs/ext4/.kunitconfig .kunit/
> $ ./tools/testing/kunit.py run
>
> After [2]:
> $ ./tools/testing/kunit.py run --kunitconfig=fs/ext4/.kunitconfig
Thanks, applied, with one minor fixup. The path to kunit.py is
./tools/testing/kunit/kunit.py
- Ted
prev parent reply other threads:[~2021-02-12 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 1:32 [PATCH] ext4: add .kunitconfig fragment to enable ext4-specific tests Daniel Latypov
2021-02-10 2:33 ` Theodore Ts'o
2021-02-10 5:44 ` Daniel Latypov
2021-02-23 0:23 ` Daniel Latypov
2021-02-12 4:22 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCYCnaEMc95hDfso@mit.edu \
--to=tytso@mit.edu \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).