From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E02C433E0 for ; Mon, 1 Mar 2021 15:09:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B5ED64DF1 for ; Mon, 1 Mar 2021 15:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236827AbhCAPJY (ORCPT ); Mon, 1 Mar 2021 10:09:24 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56407 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236914AbhCAPJR (ORCPT ); Mon, 1 Mar 2021 10:09:17 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 121F8Qrh006719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Mar 2021 10:08:27 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 9DABB15C3A88; Mon, 1 Mar 2021 10:08:26 -0500 (EST) Date: Mon, 1 Mar 2021 10:08:26 -0500 From: "Theodore Ts'o" To: Sedat Dilek Cc: linux-ext4@vger.kernel.org Subject: Re: badblocks from e2fsprogs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Mar 01, 2021 at 10:20:36AM +0100, Sedat Dilek wrote: > > root@iniza:~/DISK-HEALTH# LC_ALL=C badblocks -v -p 1 -s /dev/sdc -o > badblocks-v-p-1-s_dev-sdc_$(uname -r).txt > Checking blocks 0 to 976762583 > Checking for bad blocks (read-only test): done > Pass completed, 0 bad blocks found. (0/0/0 errors) > > root@iniza:~/DISK-HEALTH# ll > badblocks-v-p-1-s_dev-sdc_5.11.0-11646.1-amd64-clang13-cfi.txt > -rw-r--r-- 1 root root 0 28. Feb 19:33 > badblocks-v-p-1-s_dev-sdc_5.11.0-11646.1-amd64-clang13-cfi.txt > > Unfortunately, the output-file is empty. > Do I miss something (order of options for example)? Nope; the output file is a list of block numbers for which badblocks found problems. > The whole single-pass badblocks run took approx. 3 hours - last I > looked 50% was 01:26 [hh:mm]. > On stdout (and in output-file) - no summary of the total-time. > > Is that possible to have: > > Pass completed, 0 bad blocks found. (0/0/0 errors) + The output file was designed for use to be fed into mke2fs (via the -l option) or e2fsck (via the -l or -L options). So we can't change the format of the output file without breaking those programs. You will note that the output is in the badblocks standard output: Pass completed, 0 bad blocks found. (0/0/0 errors) So there should be no confusion in the mind of the person running the badblocks program. Regards, - Ted