* [PATCH] misc: remove useless code in set_inode_xattr()
@ 2021-02-26 1:22 Zhiqiang Liu
2021-03-03 0:51 ` Zhiqiang Liu
0 siblings, 1 reply; 4+ messages in thread
From: Zhiqiang Liu @ 2021-02-26 1:22 UTC (permalink / raw)
To: linux-ext4, Theodore Y. Ts'o
Cc: harshad shirwadkar, linfeilong, lihaotian, liuzhiqiang26
In set_inode_xattr(), there are two returns as follows,
-
return retval;
return 0;
-
Here, we remove useless 'return 0;' code.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
misc/create_inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/misc/create_inode.c b/misc/create_inode.c
index 54d8d343..d62e1cb4 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
retval = retval ? retval : close_retval;
}
return retval;
- return 0;
}
#else /* HAVE_LLISTXATTR */
static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: remove useless code in set_inode_xattr()
2021-02-26 1:22 [PATCH] misc: remove useless code in set_inode_xattr() Zhiqiang Liu
@ 2021-03-03 0:51 ` Zhiqiang Liu
2021-03-03 20:20 ` Andreas Dilger
0 siblings, 1 reply; 4+ messages in thread
From: Zhiqiang Liu @ 2021-03-03 0:51 UTC (permalink / raw)
To: linux-ext4, Theodore Y. Ts'o
Cc: harshad shirwadkar, linfeilong, lihaotian
ping...
On 2021/2/26 9:22, Zhiqiang Liu wrote:
>
> In set_inode_xattr(), there are two returns as follows,
> -
> return retval;
> return 0;
> -
> Here, we remove useless 'return 0;' code.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
> misc/create_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/misc/create_inode.c b/misc/create_inode.c
> index 54d8d343..d62e1cb4 100644
> --- a/misc/create_inode.c
> +++ b/misc/create_inode.c
> @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
> retval = retval ? retval : close_retval;
> }
> return retval;
> - return 0;
> }
> #else /* HAVE_LLISTXATTR */
> static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: remove useless code in set_inode_xattr()
2021-03-03 0:51 ` Zhiqiang Liu
@ 2021-03-03 20:20 ` Andreas Dilger
2021-04-02 19:57 ` Theodore Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Dilger @ 2021-03-03 20:20 UTC (permalink / raw)
To: Zhiqiang Liu
Cc: linux-ext4, Theodore Y. Ts'o, harshad shirwadkar, linfeilong,
lihaotian
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On 2021/2/26 9:22, Zhiqiang Liu wrote:
>
> In set_inode_xattr(), there are two returns as follows,
> -
> return retval;
> return 0;
> -
> Here, we remove useless 'return 0;' code.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> misc/create_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/misc/create_inode.c b/misc/create_inode.c
> index 54d8d343..d62e1cb4 100644
> --- a/misc/create_inode.c
> +++ b/misc/create_inode.c
> @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
> retval = retval ? retval : close_retval;
> }
> return retval;
> - return 0;
> }
> #else /* HAVE_LLISTXATTR */
> static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: remove useless code in set_inode_xattr()
2021-03-03 20:20 ` Andreas Dilger
@ 2021-04-02 19:57 ` Theodore Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2021-04-02 19:57 UTC (permalink / raw)
To: Andreas Dilger
Cc: Zhiqiang Liu, linux-ext4, harshad shirwadkar, linfeilong,
lihaotian
On Wed, Mar 03, 2021 at 01:20:33PM -0700, Andreas Dilger wrote:
> On 2021/2/26 9:22, Zhiqiang Liu wrote:
> >
> > In set_inode_xattr(), there are two returns as follows,
> > -
> > return retval;
> > return 0;
> > -
> > Here, we remove useless 'return 0;' code.
> >
> > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-02 19:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 1:22 [PATCH] misc: remove useless code in set_inode_xattr() Zhiqiang Liu
2021-03-03 0:51 ` Zhiqiang Liu
2021-03-03 20:20 ` Andreas Dilger
2021-04-02 19:57 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).