From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Zhang Yi <yi.zhang@huawei.com>,
linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca
Subject: Re: [PATCH v2] ext4: fix check to prevent false positive report of incorrect used inodes
Date: Fri, 9 Apr 2021 11:32:48 -0400 [thread overview]
Message-ID: <YHBzoLSdVDuUiXma@mit.edu> (raw)
In-Reply-To: <20210331122354.GH30749@quack2.suse.cz>
On Wed, Mar 31, 2021 at 02:23:54PM +0200, Jan Kara wrote:
> On Wed 31-03-21 20:15:16, Zhang Yi wrote:
> > Commit <50122847007> ("ext4: fix check to prevent initializing reserved
> > inodes") check the block group zero and prevent initializing reserved
> > inodes. But in some special cases, the reserved inode may not all belong
> > to the group zero, it may exist into the second group if we format
> > filesystem below.
> >
> > mkfs.ext4 -b 4096 -g 8192 -N 1024 -I 4096 /dev/sda
> >
> > So, it will end up triggering a false positive report of a corrupted
> > file system. This patch fix it by avoid check reserved inodes if no free
> > inode blocks will be zeroed.
> >
> > Fixes: 50122847007 ("ext4: fix check to prevent initializing reserved inodes")
> > Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
> > Suggested-by: Jan Kara <jack@suse.cz>
>
> Thanks! The patch looks good to me. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2021-04-09 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 12:15 [PATCH v2] ext4: fix check to prevent false positive report of incorrect used inodes Zhang Yi
2021-03-31 12:23 ` Jan Kara
2021-04-09 15:32 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHBzoLSdVDuUiXma@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).