From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4EEEC47083 for ; Thu, 3 Jun 2021 01:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C85B3613DC for ; Thu, 3 Jun 2021 01:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbhFCCBG (ORCPT ); Wed, 2 Jun 2021 22:01:06 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44638 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229541AbhFCCBF (ORCPT ); Wed, 2 Jun 2021 22:01:05 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1531xJ3p015418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Jun 2021 21:59:19 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2322815C3CAF; Wed, 2 Jun 2021 21:59:19 -0400 (EDT) Date: Wed, 2 Jun 2021 21:59:19 -0400 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: fix fast commit alignment issues Message-ID: References: <20210519215920.2037527-1-harshads@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519215920.2037527-1-harshads@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, May 19, 2021 at 02:59:20PM -0700, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > Fast commit recovery data on disk may not be aligned. So, when the > recovery code reads it, this patch makes sure that fast commit info > found on-disk is first memcpy-ed into an aligned variable before > accessing it. As a consequence of it, we also remove some macros that > could resulted in unaligned accesses. > > Signed-off-by: Harshad Shirwadkar Applied, thanks. - Ted