From: "Theodore Ts'o" <tytso@mit.edu>
To: Wang Jianchao <jianchao.wan9@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
lishujin@kuaishou.com
Subject: Re: [PATCH V2 5/7] ext4: get buddy cache after insert successfully
Date: Tue, 22 Jun 2021 23:06:02 -0400 [thread overview]
Message-ID: <YNKlGn3GRFCtyls7@mit.edu> (raw)
In-Reply-To: <93458049-0d43-617a-a5e7-c7e10325443a@gmail.com>
On Wed, May 26, 2021 at 04:43:43PM +0800, Wang Jianchao wrote:
> The getting of bd_bitmap_page and bd_buddy_page should be done
> after insert the ext4_free_data successfully. Otherwise, nobody
> can put them.
>
> Signed-off-by: Wang Jianchao <wangjianchao@kuaishou.com>
This looks like it's a bug fix for patch 4/7 --- is that correct? If
so, maybe we should fold this into the previous patch?
Thanks,
- Ted
next prev parent reply other threads:[~2021-06-23 3:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164ffa3b-c4d5-6967-feba-b972995a6dfb@gmail.com>
2021-05-26 8:42 ` [PATCH V2 1/7] ext4: remove the 'group' parameter of ext4_trim_extent Wang Jianchao
2021-05-27 19:47 ` Andreas Dilger
2021-06-23 13:13 ` Theodore Ts'o
2021-06-23 19:49 ` Theodore Ts'o
2021-07-02 10:27 ` Josh Triplett
2021-07-05 11:28 ` Wang Jianchao
[not found] ` <a602a6ba-2073-8384-4c8f-d669ee25c065@gmail.com>
2021-05-26 8:43 ` [PATCH V2 2/7] ext4: add new helper interface ext4_try_to_trim_range() Wang Jianchao
2021-05-27 19:48 ` Andreas Dilger
[not found] ` <49382052-6238-f1fb-40d1-b6b801b39ff7@gmail.com>
2021-05-26 8:43 ` [PATCH V2 3/7] ext4: remove the repeated comment of ext4_trim_all_free Wang Jianchao
2021-05-27 19:49 ` Andreas Dilger
[not found] ` <48e33dea-d15e-f211-0191-e01bd3eb17b3@gmail.com>
2021-05-26 8:43 ` [PATCH V2 4/7] ext4: add new helper interface ext4_insert_free_data Wang Jianchao
2021-05-27 20:09 ` Andreas Dilger
2021-05-28 3:40 ` Wang Jianchao
[not found] ` <67eeb65a-d413-c4f9-c06f-d5dcceca0e4f@gmail.com>
2021-05-26 8:43 ` [PATCH V2 5/7] ext4: get buddy cache after insert successfully Wang Jianchao
2021-06-23 3:06 ` Theodore Ts'o [this message]
[not found] ` <0b7915bc-193a-137b-4e52-8aaef8d6fef3@gmail.com>
2021-05-26 8:43 ` [PATCH V2 6/7] ext4: use bb_free_root to get the free data entry Wang Jianchao
2021-05-26 8:44 ` [PATCH V2 7/7] ext4: get discard out of jbd2 commit kthread contex Wang Jianchao
2021-05-27 20:18 ` Andreas Dilger
2021-05-28 3:06 ` Wang Jianchao
2021-06-22 0:55 ` Josh Triplett
2023-09-06 0:11 ` Sarthak Kukreti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNKlGn3GRFCtyls7@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jianchao.wan9@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lishujin@kuaishou.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).