From: "Theodore Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Ritesh Harjani <riteshh@linux.ibm.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 5/9] generic/031: Fix the test case for 64k blocksize config
Date: Wed, 30 Jun 2021 13:18:42 -0400 [thread overview]
Message-ID: <YNyncumuIpVw/T1E@mit.edu> (raw)
In-Reply-To: <20210630155001.GA13743@locust>
On Wed, Jun 30, 2021 at 08:50:01AM -0700, Darrick J. Wong wrote:
> > +# fcollapse need offset and len to be multiple of blocksize for filesystems
> > +# hence make this test work with 64k blocksize as well.
> ...
>
> What if the blocksize is 32k?
... or 8k? or 16k? (which might be more likely)
How bout if we change the offsets and lengths in the test so they are
all multiples of 64k, and adjusting 31.out appropriately? That will
allow the test to work for block sizes up to 64k without needing to
having a special case for 031.out.64k.
I don't know of architectures with a page size > 64k (yet), so this
should hold us for a while.
- Ted
next prev parent reply other threads:[~2021-06-30 17:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 6:28 [PATCH 0/9] 64K blocksize related fixes Ritesh Harjani
2021-06-14 6:28 ` [PATCH 1/9] ext4/003: Fix this test on 64K platform for dax config Ritesh Harjani
2021-06-30 16:27 ` Theodore Ts'o
2021-07-08 6:24 ` Ritesh Harjani
2021-07-08 12:51 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 2/9] ext4/027: Correct the right code of block and inode bitmap Ritesh Harjani
2021-06-14 16:40 ` Darrick J. Wong
2021-06-14 6:28 ` [PATCH 3/9] ext4/306: Add -b blocksize parameter too to avoid failure with DAX config Ritesh Harjani
2021-06-30 16:29 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 4/9] ext4/022: exclude this test for dax config on 64KB pagesize platform Ritesh Harjani
2021-06-30 16:36 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 5/9] generic/031: Fix the test case for 64k blocksize config Ritesh Harjani
2021-06-30 15:50 ` Darrick J. Wong
2021-06-30 17:18 ` Theodore Ts'o [this message]
2021-07-08 9:49 ` Ritesh Harjani
2021-06-14 6:28 ` [PATCH 6/9] gitignore: Add 031.out file to .gitignore Ritesh Harjani
2021-06-30 16:36 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 7/9] generic/620: Remove -b blocksize option for ext4 Ritesh Harjani
2021-06-30 17:07 ` Theodore Ts'o
2021-07-08 10:01 ` Ritesh Harjani
2021-06-14 6:28 ` [PATCH 8/9] common/attr: Cleanup end of line whitespaces issues Ritesh Harjani
2021-06-30 15:50 ` Darrick J. Wong
2021-06-30 17:19 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 9/9] common/attr: Reduce MAX_ATTRS to leave some overhead for 64K blocksize Ritesh Harjani
2021-06-30 15:51 ` Darrick J. Wong
2021-06-30 19:20 ` Theodore Ts'o
2021-07-09 5:12 ` Ritesh Harjani
2021-06-30 13:30 ` [PATCH 0/9] 64K blocksize related fixes Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNyncumuIpVw/T1E@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).