From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CA2C11F69 for ; Wed, 30 Jun 2021 17:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F127661492 for ; Wed, 30 Jun 2021 17:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbhF3RVT (ORCPT ); Wed, 30 Jun 2021 13:21:19 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42286 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232586AbhF3RVS (ORCPT ); Wed, 30 Jun 2021 13:21:18 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15UHIgcQ024107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 13:18:42 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3F26B15C3C8E; Wed, 30 Jun 2021 13:18:42 -0400 (EDT) Date: Wed, 30 Jun 2021 13:18:42 -0400 From: "Theodore Ts'o" To: "Darrick J. Wong" Cc: Ritesh Harjani , fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 5/9] generic/031: Fix the test case for 64k blocksize config Message-ID: References: <20210630155001.GA13743@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630155001.GA13743@locust> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 08:50:01AM -0700, Darrick J. Wong wrote: > > +# fcollapse need offset and len to be multiple of blocksize for filesystems > > +# hence make this test work with 64k blocksize as well. > ... > > What if the blocksize is 32k? ... or 8k? or 16k? (which might be more likely) How bout if we change the offsets and lengths in the test so they are all multiples of 64k, and adjusting 31.out appropriately? That will allow the test to work for block sizes up to 64k without needing to having a special case for 031.out.64k. I don't know of architectures with a page size > 64k (yet), so this should hold us for a while. - Ted