From: "Theodore Ts'o" <tytso@mit.edu>
To: Tahsin Erdogan <trdgn@amazon.com>
Cc: Jan Kara <jack@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: eliminate bogus error in ext4_data_block_valid_rcu()
Date: Sat, 3 Jul 2021 20:58:02 -0400 [thread overview]
Message-ID: <YOEHmjjY9facxtIY@mit.edu> (raw)
In-Reply-To: <20210703230555.4093-1-trdgn@amazon.com>
On Sat, Jul 03, 2021 at 04:05:55PM -0700, Tahsin Erdogan wrote:
> Mainline commit ce9f24cccdc0 ("ext4: check journal inode extents more carefully")
> enabled validity checks for journal inode's data blocks. This change got
> ported to stable branches, but the backport for 4.19 has a bug where it will
> flag an error even when system block entry's inode number matches journal
> inode.
Tahsin,
If I understand the commit description, this patch is only intended
for the 4.19 stable kernel. If this is the case, I'd suggest using
the Subject prefix [PATCH 4.19] for future patches. This is more
likely to be clearer (via a quick glance at the Subject line) for
subsystem maintainers, as well as for stable kernel maintainers, that
this is meant for the stable kernel. It would perhaps also be useful
if you could indicate whether a similar fix is needed for 4.14, and
other older LTS kernels, or whether the only stable backport which had
this bug was 4.19.
Cheers,
- Ted
P.S. Great to see you've landed at Amazon! It's been a while; if I
have a chance to make it out to Seattle, one of these days, it would
be great to catch up.
next prev parent reply other threads:[~2021-07-04 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 23:05 [PATCH] ext4: eliminate bogus error in ext4_data_block_valid_rcu() Tahsin Erdogan
2021-07-04 0:58 ` Theodore Ts'o [this message]
2021-07-04 1:35 ` [PATCH 4.19] " Erdogan, Tahsin
2021-07-05 7:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOEHmjjY9facxtIY@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trdgn@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).