From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70C1C07E95 for ; Fri, 16 Jul 2021 03:58:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACF76613CF for ; Fri, 16 Jul 2021 03:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbhGPEBt (ORCPT ); Fri, 16 Jul 2021 00:01:49 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39829 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229507AbhGPEBs (ORCPT ); Fri, 16 Jul 2021 00:01:48 -0400 Received: from callcc.thunk.org (96-65-121-81-static.hfc.comcastbusiness.net [96.65.121.81]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16G3wjI1028804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jul 2021 23:58:46 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 505204202F5; Thu, 15 Jul 2021 23:58:45 -0400 (EDT) Date: Thu, 15 Jul 2021 23:58:45 -0400 From: "Theodore Y. Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, artem.blagodarenko@gmail.com, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH v2 11/12] misc/lsattr: check whether path is NULL in lsattr_dir_proc() Message-ID: References: <20210630082724.50838-2-wuguanghao3@huawei.com> <20210630082724.50838-12-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630082724.50838-12-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 04:27:23PM +0800, wuguanghao wrote: > > diff --git a/misc/lsattr.c b/misc/lsattr.c > index 0d954376..f3212069 100644 > --- a/misc/lsattr.c > +++ b/misc/lsattr.c > @@ -144,6 +144,12 @@ static int lsattr_dir_proc (const char * dir_name, struct dirent * de, > int dir_len = strlen(dir_name); > > path = malloc(dir_len + strlen (de->d_name) + 2); > + if (!path) { > + fprintf(stderr, "%s", > + _("Couldn't allocate path variable " > + "in lsattr_dir_proc")); > + return -1; > + } The string is missing a closing newline. Also, why not? fputs(_("Couldn't allocate path variable in lsattr_dir_proc"), stderr); - Ted