From: "Theodore Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH RESEND] tests: skip u_direct_io if losetup fails
Date: Fri, 6 Aug 2021 11:23:55 -0400 [thread overview]
Message-ID: <YQ1UCzIQLliQ3TAU@mit.edu> (raw)
In-Reply-To: <20210805154328.GB3601392@magnolia>
On Thu, Aug 05, 2021 at 08:43:28AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This new test requires a loop device to run testing. While it checks
> for some "obvious" parameters that might cause the test to fail such as
> not being root and no losetup executable, it doesn't actually check that
> the losetup -a call succeeds. This causes a test regression in my
> package building container (where there is only a minimal /dev with no
> loop devices available) so I can't build debian packages.
>
> Fix the test to skip out if we can't create a loop device.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Applied, thanks.
- Ted
prev parent reply other threads:[~2021-08-06 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 15:43 [PATCH RESEND] tests: skip u_direct_io if losetup fails Darrick J. Wong
2021-08-06 15:23 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ1UCzIQLliQ3TAU@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).