From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/9] libext2fs: Support for orphan file feature
Date: Tue, 3 Aug 2021 13:57:53 -0400 [thread overview]
Message-ID: <YQmDoXZSPjY7xq12@mit.edu> (raw)
In-Reply-To: <YQl+u2HwLV3f6cUE@mit.edu>
On Tue, Aug 03, 2021 at 01:36:59PM -0400, Theodore Ts'o wrote:
> On Mon, Jul 12, 2021 at 05:43:10PM +0200, Jan Kara wrote:
> > @@ -825,6 +826,7 @@ struct ext2_super_block {
> > #define EXT4_FEATURE_RO_COMPAT_GDT_CSUM 0x0010
> > #define EXT4_FEATURE_RO_COMPAT_DIR_NLINK 0x0020
> > #define EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE 0x0040
> > +#define EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT 0x0080
> > #define EXT4_FEATURE_RO_COMPAT_QUOTA 0x0100
> > #define EXT4_FEATURE_RO_COMPAT_BIGALLOC 0x0200
>
> (This isn't a full review of the patch, but just a quick feedback of
> what I've noticed so far.)
>
> Since Andreas has requested that we not get rid of the
> RO_COMPAT_SNAPSHOT, I'm using 0x10000 for
> EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT in my testing.
>
> I also noted a number of new GCC warnings when running "make gcc-wall"
> on lib/ext2fs after applying this commit.
Sorry, I just realized I had used b4 to grab the v3 instead of the v4
of the patch series. Fortunately it looks like the 2nd and 3rd
patches hadn't changed between the two patch series, so I'll regroup
and try again this time with the v4 patches.
- Ted
next prev parent reply other threads:[~2021-08-03 17:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 10:57 [PATCH 0/9 v3] e2fsprogs: Support for orphan file feature Jan Kara
2021-06-16 10:57 ` [PATCH 1/9] ext2fs: Drop HAS_SNAPSHOT feature Jan Kara
2021-06-16 10:57 ` [PATCH 2/9] quota: Do not account space used by project quota file to quota Jan Kara
2021-08-03 16:13 ` Theodore Ts'o
2021-08-04 12:15 ` Jan Kara
2021-06-16 10:57 ` [PATCH 3/9] e2image: Dump quota files Jan Kara
2021-08-03 16:15 ` Theodore Ts'o
2021-06-16 10:57 ` [PATCH 4/9] libext2fs: Support for orphan file feature Jan Kara
2021-08-03 17:36 ` Theodore Ts'o
2021-08-03 17:57 ` Theodore Ts'o [this message]
2021-06-16 10:57 ` [PATCH 5/9] mke2fs: Add support for orphan_file feature Jan Kara
2021-06-16 10:57 ` [PATCH 6/9] e2fsck: Add support for handling orphan file Jan Kara
2021-06-16 10:57 ` [PATCH 7/9] tune2fs: Add support for orphan_file feature Jan Kara
2021-06-16 10:57 ` [PATCH 8/9] mke2fs: Add orphan_file feature into mke2fs.conf Jan Kara
2021-06-16 10:57 ` [PATCH 9/9] dumpe2fs, debugfs, e2image: Add support for orphan file Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2021-07-12 15:43 [PATCH 0/9 v4] e2fsprogs: Support for orphan file feature Jan Kara
2021-07-12 15:43 ` [PATCH 4/9] libext2fs: " Jan Kara
2021-08-03 16:57 ` Theodore Ts'o
2021-08-03 17:40 ` Theodore Ts'o
2021-08-04 9:25 ` Jan Kara
2021-08-04 10:13 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQmDoXZSPjY7xq12@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).