From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 6/9] e2fsck: Add support for handling orphan file
Date: Tue, 3 Aug 2021 14:56:35 -0400 [thread overview]
Message-ID: <YQmRY5ZaLxpN4ZID@mit.edu> (raw)
In-Reply-To: <20210712154315.9606-7-jack@suse.cz>
On Mon, Jul 12, 2021 at 05:43:12PM +0200, Jan Kara wrote:
> diff --git a/e2fsck/problem.h b/e2fsck/problem.h
> index 24cdcf9b90f7..0611d71f9e03 100644
> --- a/e2fsck/problem.h
> +++ b/e2fsck/problem.h
> @@ -717,6 +729,15 @@ struct problem_context {
> #define PR_1_HTREE_CANNOT_SIPHASH 0x01008E
>
>
> +/* Orphan file inode is not a regular file */
> +#define PR_1_ORPHAN_FILE_BAD_MODE 0x01007F
> +
> +/* Orphan file inode is not in use, but contains data */
> +#define PR_1_ORPHAN_FILE_NOT_CLEAR 0x010080
> +
> +/* Orphan file inode is not clear */
> +#define PR_1_ORPHAN_INODE_NOT_CLEAR 0x01007F
> +
The problem codes for PR_1_ORPHAN_FILE_BAD_MODE,
PR_1_ORPHAN_FILE_NOT_CLEAR, and PR_1_ORPHAN_INODE_NOT_CLEAR overlap
with pre-existing problem codes. This was picked up by running "make
check", either at the top-level or in the e2fsck subdirectory. I've
fixed this up in my repo.
I've pushed out the slightly massaged e2fsprogs parallel orphan list
patches on the "pu" (proposed updates, a terminology that Junio uses
for the git repo) branch, for folks who want to experiment with the
parallel orphan list patches.
- Ted
next prev parent reply other threads:[~2021-08-03 18:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:43 [PATCH 0/9 v4] e2fsprogs: Support for orphan file feature Jan Kara
2021-07-12 15:43 ` [PATCH 1/9] ext2fs: Drop HAS_SNAPSHOT feature Jan Kara
2021-07-12 18:20 ` Andreas Dilger
2021-07-13 8:11 ` Jan Kara
2021-07-12 15:43 ` [PATCH 2/9] quota: Do not account space used by project quota file to quota Jan Kara
2021-07-12 15:43 ` [PATCH 3/9] e2image: Dump quota files Jan Kara
2021-07-12 15:43 ` [PATCH 4/9] libext2fs: Support for orphan file feature Jan Kara
2021-08-03 16:57 ` Theodore Ts'o
2021-08-03 17:40 ` Theodore Ts'o
2021-08-04 9:25 ` Jan Kara
2021-08-04 10:13 ` Jan Kara
2021-07-12 15:43 ` [PATCH 5/9] mke2fs: Add support for orphan_file feature Jan Kara
2021-07-12 15:43 ` [PATCH 6/9] e2fsck: Add support for handling orphan file Jan Kara
2021-08-03 18:56 ` Theodore Ts'o [this message]
2021-07-12 15:43 ` [PATCH 7/9] tune2fs: Add support for orphan_file feature Jan Kara
2021-07-12 15:43 ` [PATCH 8/9] mke2fs: Add orphan_file feature into mke2fs.conf Jan Kara
2021-08-04 19:04 ` Theodore Ts'o
2021-08-05 15:00 ` Jan Kara
2021-07-12 15:43 ` [PATCH 9/9] dumpe2fs, debugfs, e2image: Add support for orphan file Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2021-06-16 10:57 [PATCH 0/9 v3] e2fsprogs: Support for orphan file feature Jan Kara
2021-06-16 10:57 ` [PATCH 6/9] e2fsck: Add support for handling orphan file Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQmRY5ZaLxpN4ZID@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).