From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D5EC4338F for ; Fri, 20 Aug 2021 10:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C03B6112E for ; Fri, 20 Aug 2021 10:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238508AbhHTKWA (ORCPT ); Fri, 20 Aug 2021 06:22:00 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:32928 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237840AbhHTKV7 (ORCPT ); Fri, 20 Aug 2021 06:21:59 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9662422171; Fri, 20 Aug 2021 10:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629454881; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FhNk8lxe6JJrFZjgNC31q5GHymCThZLZrgrFHACGfgY=; b=ttmN+OhUloeFYb2WW86BepRW9xvOdfe6ZIWVOONttcJTVnfmvj8/MgH64mSWAPb0KD91Ad +bDVJKAaCPUrp0h36eVeAMV7b6hJ/u6Lq8CMr0c13YMW40aJCkObf8hlNPgNZF3NCqrmsZ MuoiF5U/IcSlTbHI0DRkCCES05+ALQQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629454881; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FhNk8lxe6JJrFZjgNC31q5GHymCThZLZrgrFHACGfgY=; b=FMBf9bia21Gc0KmlG72n/vTfjhluMtYpereR/+CfD3LGO/tKB8ZuCH2GGmBybNKrlPJ4Wy rhCOO0VRGrZSAXCg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 38EC113ABF; Fri, 20 Aug 2021 10:21:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id MWvSCyGCH2GHZwAAGKfGzw (envelope-from ); Fri, 20 Aug 2021 10:21:21 +0000 Date: Fri, 20 Aug 2021 12:21:19 +0200 From: Petr Vorel To: Amir Goldstein Cc: Gabriel Krisman Bertazi , kernel@collabora.com, Khazhismel Kumykov , Matthew Bobrowski , Jan Kara , Ext4 , LTP List Subject: Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Message-ID: Reply-To: Petr Vorel References: <20210802214645.2633028-1-krisman@collabora.com> <20210802214645.2633028-4-krisman@collabora.com> <87fsvphksu.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi all, > No problem. That's what review is for ;-) > BTW, unless anyone is specifically interested I don't think there > is a reason to re post the test patches before the submission request. > Certainly not for the small fixes that I requested. > I do request that you post a link to a branch with the fixed test > so that we can experiment with the kernel patches. > I've also CC'ed Matthew who may want to help with review of the test > and man page that you posted in the cover letter [1]. @Amir Thanks a lot for your review, agree with all you mentioned. @Gabriel Thanks for your contribution. I'd also consider squashing some of the commits. Kind regards, Petr > Thanks, > Amir. > [1] https://lore.kernel.org/linux-ext4/20210802214645.2633028-1-krisman@collabora.com/T/#m9cf637c6aca94e28390f61deac5a53afbc9e88ae