From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: yangerkun <yangerkun@huawei.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
yukuai3@huawei.com
Subject: Re: [PATCH] ext4: stop return ENOSPC from ext4_issue_zeroout
Date: Mon, 16 Aug 2021 10:16:16 -0400 [thread overview]
Message-ID: <YRpzMK6tj0BBlDK8@mit.edu> (raw)
In-Reply-To: <20210816100545.GF24793@quack2.suse.cz>
On Mon, Aug 16, 2021 at 12:05:45PM +0200, Jan Kara wrote:
>
> Yes, that looks indeed better. I'd note that even splitting extent may fail
> due to ENOSPC on thin-provisioned storage but the chances are *much* lower.
Indeed, any kind of metadata update (updating an inode atime, creating
a new inode, deleting a directory entry, etc.) can fail due to ENOSPC
on thin-provision storage, leading to a potentially corrupted file
system since some writes will succeed, while others won't --- and
that's not a scenario that's super well tested, nor is there much we
can do other than remounting the file system read/only or forcing a
reboot.
But at least we won't throw the kernel into an infinite loop, which is
what yangerkun was reporting...
- Ted
prev parent reply other threads:[~2021-08-16 14:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 12:50 [PATCH] ext4: stop return ENOSPC from ext4_issue_zeroout yangerkun
2021-08-04 13:35 ` Jan Kara
2021-08-13 15:18 ` Theodore Ts'o
2021-08-13 21:27 ` [PATCH] ext4: if zeroout fails fall back to splitting the extent node Theodore Ts'o
2021-08-14 2:15 ` yangerkun
2021-08-16 6:57 ` yangerkun
2021-09-26 11:35 ` yangerkun
2021-11-23 9:27 ` Jan Kara
2021-11-24 9:01 ` yangerkun
2021-11-24 10:37 ` Jan Kara
2021-11-24 12:11 ` yangerkun
2021-11-24 17:15 ` Jan Kara
2021-08-16 10:05 ` [PATCH] ext4: stop return ENOSPC from ext4_issue_zeroout Jan Kara
2021-08-16 14:16 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRpzMK6tj0BBlDK8@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).