From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Roman Anufriev <dotdot@yandex-team.ru>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, wshilong@ddn.com,
dmtrmonakhov@yandex-team.ru
Subject: Re: [PATCH] ext4: compare inode's i_projid with EXT4_DEF_PROJID rather than check EXT4_INODE_PROJINHERIT flag
Date: Tue, 7 Dec 2021 14:34:07 -0500 [thread overview]
Message-ID: <Ya+3L3gBFCeWZki7@mit.edu> (raw)
In-Reply-To: <alpine.OSX.2.23.453.2112071702150.70498@dotdot-osx>
On Tue, Dec 07, 2021 at 05:05:19PM +0300, Roman Anufriev wrote:
> > Commit 7ddf79a10395 ("ext4: only set project inherit bit for directory")
> > removes EXT4_INODE_PROJINHERIT flag from regular files. This makes
> > ext4_statfs() output incorrect (function does not apply quota limits
> > on used/available space, etc) when called on dentry of regular file
> > with project quota enabled.
Under what circumstance is userspace trying to call statfs on a file
descriptor?
Removing the test for EXT4_INODE_PROJINHERIT will cause
incorrect/misleading results being returned in the case where we have
a directory where a directory hierarchy is using project id's, but
which is *not* using PROJINHERIT.
- Ted
next prev parent reply other threads:[~2021-12-07 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 13:18 [PATCH] ext4: compare inode's i_projid with EXT4_DEF_PROJID rather than check EXT4_INODE_PROJINHERIT flag Roman Anufriev
2021-12-07 14:05 ` Roman Anufriev
2021-12-07 19:34 ` Theodore Y. Ts'o [this message]
2021-12-09 22:53 ` Andreas Dilger
2021-12-09 23:30 ` Dave Chinner
2021-12-10 19:53 ` Roman Anufriev
2021-12-10 19:53 ` Roman Anufriev
2021-12-11 0:49 ` Darrick J. Wong
2021-12-10 19:55 ` Roman Anufriev
2021-12-14 5:06 ` Dave Chinner
2021-12-17 0:17 ` Andreas Dilger
2021-12-17 2:39 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya+3L3gBFCeWZki7@mit.edu \
--to=tytso@mit.edu \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=dotdot@yandex-team.ru \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox