* [PATCH] test-appliance: add ext4/050 to encrypt.exclude
@ 2021-12-18 4:08 Theodore Ts'o
2021-12-19 2:21 ` Eric Biggers
0 siblings, 1 reply; 3+ messages in thread
From: Theodore Ts'o @ 2021-12-18 4:08 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Leah Rumancik, Theodore Ts'o
The ext4/050 test can't handle encrypted directories, so skip it for
now.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
.../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index f3c7a959..21a8b45f 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -12,6 +12,11 @@ ext4/028
# file systems with encryption enabled can't be mounted with ext3
ext4/044
+# This test to make sure ext4 directory entries are appropriately
+# wiped after a file is deleted, or after htree operations is
+# incompatible with an encrypted directory.
+ext4/048
+
# These tests use the old-style quota support where the quota files are user
# files instead of hidden inodes. This isn't compatible with
# test_dummy_encryption, as it causes the quota files to be encrypted.
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test-appliance: add ext4/050 to encrypt.exclude
2021-12-18 4:08 [PATCH] test-appliance: add ext4/050 to encrypt.exclude Theodore Ts'o
@ 2021-12-19 2:21 ` Eric Biggers
2021-12-19 4:05 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2021-12-19 2:21 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, Leah Rumancik
On Fri, Dec 17, 2021 at 11:08:14PM -0500, Theodore Ts'o wrote:
> The ext4/050 test can't handle encrypted directories, so skip it for
> now.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> index f3c7a959..21a8b45f 100644
> --- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> +++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> @@ -12,6 +12,11 @@ ext4/028
> # file systems with encryption enabled can't be mounted with ext3
> ext4/044
>
> +# This test to make sure ext4 directory entries are appropriately
> +# wiped after a file is deleted, or after htree operations is
> +# incompatible with an encrypted directory.
> +ext4/048
The commit message says ext4/050, but the test added to the list is ext4/048.
Is ext4/048 the one intended?
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test-appliance: add ext4/050 to encrypt.exclude
2021-12-19 2:21 ` Eric Biggers
@ 2021-12-19 4:05 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2021-12-19 4:05 UTC (permalink / raw)
To: Eric Biggers; +Cc: Ext4 Developers List, Leah Rumancik
On Sat, Dec 18, 2021 at 08:21:06PM -0600, Eric Biggers wrote:
> On Fri, Dec 17, 2021 at 11:08:14PM -0500, Theodore Ts'o wrote:
> > The ext4/050 test can't handle encrypted directories, so skip it for
> > now.
> >
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> > .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> > index f3c7a959..21a8b45f 100644
> > --- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> > +++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> > @@ -12,6 +12,11 @@ ext4/028
> > # file systems with encryption enabled can't be mounted with ext3
> > ext4/044
> >
> > +# This test to make sure ext4 directory entries are appropriately
> > +# wiped after a file is deleted, or after htree operations is
> > +# incompatible with an encrypted directory.
> > +ext4/048
>
> The commit message says ext4/050, but the test added to the list is ext4/048.
> Is ext4/048 the one intended?
Yes, it's the commit message that was incorrect. Thanks for pointing
that out. I'll fix the commit description in my tree.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-19 4:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-18 4:08 [PATCH] test-appliance: add ext4/050 to encrypt.exclude Theodore Ts'o
2021-12-19 2:21 ` Eric Biggers
2021-12-19 4:05 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).