From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] xfstests-bld: add ext4/044 to adv.exclude
Date: Tue, 14 Dec 2021 23:07:03 -0500 [thread overview]
Message-ID: <Yblp57PzXr0MVfdy@mit.edu> (raw)
In-Reply-To: <20211214205617.17233-1-enwlinux@gmail.com>
On Tue, Dec 14, 2021 at 03:56:17PM -0500, Eric Whitney wrote:
> Test ext4/044 fails when run in the adv test case because it explicitly
> attempts to mount a test file system created with the inline_data
> feature as ext3. The inline_data feature and ext3 are incompatible,
> and the mount attempt fails.
>
> This test did not fail in earlier xfstests-bld versions because the
> features included in adv were different. In particular, the 64bit
> feature was applied, and this had an unfortunate side effect.
> Because the 64bit feature requires extents, and because the test
> attempts to create an ext3 file system, the initial attempt actually
> failed. This was hidden by behavior in the xfstest function
> _scratch_do_mkfs, which then attempted to create the file system without
> the supplied "extra" mkfs options (those supplied for the adv test case).
> So, the test file system was not created with inline_data, the explicit
> attempt to mount the test file system as ext3 succeeded, and the test
> passed without testing anything particular to the adv test case.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2021-12-15 4:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 20:56 [PATCH] xfstests-bld: add ext4/044 to adv.exclude Eric Whitney
2021-12-15 4:07 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yblp57PzXr0MVfdy@mit.edu \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox