From: "Theodore Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, adilger@dilger.ca
Subject: Re: [PATCH 1/2] ext4: Change s_last_trim_minblks type to unsigned long
Date: Tue, 4 Jan 2022 22:52:30 -0500 [thread overview]
Message-ID: <YdUV/pYn1DP/ECKz@mit.edu> (raw)
In-Reply-To: <20211103145122.17338-1-lczerner@redhat.com>
On Wed, Nov 03, 2021 at 03:51:21PM +0100, Lukas Czerner wrote:
> There is no good reason for the s_last_trim_minblks to be atomic. There is
> no data integrity needed and there is no real danger in setting and
> reading it in a racy manner. Change it to be unsigned long, the same type
> as s_clusters_per_group which is the maximum that's allowed.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Suggested-by: Andreas Dilger <adilger@dilger.ca>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
prev parent reply other threads:[~2022-01-05 3:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 14:51 [PATCH 1/2] ext4: Change s_last_trim_minblks type to unsigned long Lukas Czerner
2021-11-03 14:51 ` [PATCH v3 2/2] ext4: Allow to change s_last_trim_minblks via sysfs Lukas Czerner
2021-11-03 20:20 ` Andreas Dilger
2021-12-20 15:13 ` Lukas Czerner
2022-01-05 3:53 ` Theodore Ts'o
2021-11-03 20:20 ` [PATCH 1/2] ext4: Change s_last_trim_minblks type to unsigned long Andreas Dilger
2022-01-05 3:52 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdUV/pYn1DP/ECKz@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).