From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51CCAC433F5 for ; Wed, 9 Feb 2022 19:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233539AbiBITZW (ORCPT ); Wed, 9 Feb 2022 14:25:22 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:43896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234369AbiBITZU (ORCPT ); Wed, 9 Feb 2022 14:25:20 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3F6E00D0F0 for ; Wed, 9 Feb 2022 11:25:12 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id bg21-20020a05600c3c9500b0035283e7a012so2412508wmb.0 for ; Wed, 09 Feb 2022 11:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9X6kiHxpGEazzvkQHp8JnSwgUsJv8D0X/1igB1bJ0oM=; b=F+1sc9LG9Zusg8VEVpmo/a8vGlBpqMWse1p/RFAUMyYeq8iwZj3MRa7hjavr8KL9Wl jEdeEg8CSnXfgTg6u+0HhVo3iieUx/mqE2aRvLDuwyghlMBvJ6dj+riFgrqwt1R3411+ LH/975H10YT9+feSLn8PkRoZMV8B0S/ORAWIQrR6t38RKCx/mNROV0o+pk/oLaF+ivxr shuEKu8D27Sd0379yjauUYuSJbvnPQZDc5rpwQapN1ScgY21I+TSz91lMvAXDtJlvOe4 rxvKuPYZb4eivldj0ZoVreDkYl6QuJsstf7YlKapOeJ+mhh/P5E/lW1qfNaCgDAlQEBE +ybg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9X6kiHxpGEazzvkQHp8JnSwgUsJv8D0X/1igB1bJ0oM=; b=MhF8sJ9CdGdygsh1Z13lkeEDXf4iLBlzxpl0SLXuuapqJGUQeKMxkm7vr8On7VZJ+E KdKKRA9ybS4SFyccKUyz2HRCrpIEYTbgEeoj5bMW2eqSL+YVSvpe6599s8W7tadJT0Ke szq0VDxlrBTbqSfYf10vaH4rO0NT+kcmqsy8I1XKf+GsV7FzpCvp933AcOpaw21uMM9+ qMEaNztGpjFLfaX9sfY5WhHPkbOwT9UiP7wCpntNx9c4azIaSLLGyPLkEplOglM9FKom n2bvWgtUlb+WO7XM5FpkY/hVOCOc9YgFC+EA89dKPM9jTnUs5nJIP493Bp+c6ROo+Xmu v5tg== X-Gm-Message-State: AOAM531uRjPMzqOtcxeTYi+C4SsxyHaE2WvpUztAlcavQbZ5TGl8ZFXy bBtn2VqXd6qbcooPFBGlZH6HlA== X-Google-Smtp-Source: ABdhPJxCUh4sor/h3+HFTKlhR6E08fCeHYcKOJMGBMEAnXI+4nuwI1jwNHyvV7w8k63ICgSJT0jJAg== X-Received: by 2002:a7b:c38b:: with SMTP id s11mr3995713wmj.8.1644434709820; Wed, 09 Feb 2022 11:25:09 -0800 (PST) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id z5sm6993811wmp.10.2022.02.09.11.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 11:25:09 -0800 (PST) Date: Wed, 9 Feb 2022 19:25:05 +0000 From: Lee Jones To: Matthew Wilcox Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, Stable , Dave Chinner , Goldwyn Rodrigues , "Darrick J . Wong" , Bob Peterson , Damien Le Moal , Theodore Ts'o , Andreas Gruenbacher , Ritesh Harjani , Johannes Thumshirn , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, syzbot+0ed9f769264276638893@syzkaller.appspotmail.com Subject: Re: [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures" Message-ID: References: <20220209085243.3136536-1-lee.jones@linaro.org> <20220209150904.GA22025@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 09 Feb 2022, Matthew Wilcox wrote: > On Wed, Feb 09, 2022 at 03:59:48PM +0000, Lee Jones wrote: > > On Wed, 09 Feb 2022, Christoph Hellwig wrote: > > > > > On Wed, Feb 09, 2022 at 08:52:43AM +0000, Lee Jones wrote: > > > > This reverts commit 60263d5889e6dc5987dc51b801be4955ff2e4aa7. > > > > > > > > Reverting since this commit opens a potential avenue for abuse. > > > > > > > > The C-reproducer and more information can be found at the link below. > > > > > > > > With this patch applied, I can no longer get the repro to trigger. > > > > > > Well, maybe you should actually debug and try to understand what is > > > going on before blindly reverting random commits. > > > > That is not a reasonable suggestion. > > > > Requesting that someone becomes an area expert on a huge and complex > > subject such as file systems (various) in order to fix your broken > > code is not rational. > > Sending a patch to revert a change you don't understand is also > not rational. If you've bisected it to a single change -- great! > If reverting the patch still fixes the bug -- also great! But > don't send a patch when you clearly don't understand what the > patch did. If reverting isn't the correct thing to do here, please consider this as a bug report. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog