linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
	dm-devel@redhat.com, linux-block@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-raid@vger.kernel.org,
	Theodore Ts'o <tytso@mit.edu>, Song Liu <song@kernel.org>
Subject: Re: remove bio_devname
Date: Mon, 7 Mar 2022 11:45:53 -0500	[thread overview]
Message-ID: <YiY2wUVIz3NXIjlc@redhat.com> (raw)
In-Reply-To: <164666057398.15541.7415780807920631127.b4-ty@kernel.dk>

On Mon, Mar 07 2022 at  8:42P -0500,
Jens Axboe <axboe@kernel.dk> wrote:

> On Fri, 4 Mar 2022 19:00:55 +0100, Christoph Hellwig wrote:
> > this series removes the bio_devname helper and just switches all users
> > to use the %pg format string directly.
> > 
> > Diffstat
> >  block/bio.c               |    6 ------
> >  block/blk-core.c          |   25 +++++++------------------
> >  drivers/block/pktcdvd.c   |    9 +--------
> >  drivers/md/dm-crypt.c     |   10 ++++------
> >  drivers/md/dm-integrity.c |    5 ++---
> >  drivers/md/md-multipath.c |    9 ++++-----
> >  drivers/md/raid1.c        |    5 ++---
> >  drivers/md/raid5-ppl.c    |   13 ++++---------
> >  fs/ext4/page-io.c         |    5 ++---
> >  include/linux/bio.h       |    2 --
> >  10 files changed, 26 insertions(+), 63 deletions(-)
> > 
> > [...]
> 
> Applied, thanks!
> 
> [01/10] block: fix and cleanup bio_check_ro
>         commit: 57e95e4670d1126c103305bcf34a9442f49f6d6a
> [02/10] block: remove handle_bad_sector
>         commit: ad740780bbc2fe37856f944dbbaff07aac9db9e3
> [03/10] pktcdvd: remove a pointless debug check in pkt_submit_bio
>         commit: 47c426d5241795cfcd9be748c44d1b2e2987ce70


> [04/10] dm-crypt: stop using bio_devname
>         commit: 66671719650085f92fd460d2a356c33f9198dd35
> [05/10] dm-integrity: stop using bio_devname
>         commit: 0a806cfde82fcd1fb856864e33d17c68d1b51dee
> [06/10] md-multipath: stop using bio_devname

I had already picked these 2 up.. but happy to drop them.

>         commit: ee1925bd834418218c782c94e889f826d40b14d5
> [07/10] raid1: stop using bio_devname
>         commit: ac483eb375fa4a815a515945a5456086c197430e
> [08/10] raid5-ppl: stop using bio_devname
>         commit: c7dec4623c9cde20dad8de319d177ed6aa382aaa
> [09/10] ext4: stop using bio_devname
>         commit: 734294e47a2ec48fd25dcf2d96cdf2c6c6740c00
> [10/10] block: remove bio_devname
>         commit: 97939610b893de068c82c347d06319cd231a4602

I also picked up 2 previous patches from hch too:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=977ff73e64151d94811f4ba905419c90573f63e1
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=385411ffba0c3305491346b98ba4d2cd8063f002

Should those go through block too? Or is there no plan to remove
bdevname()?

Thanks,
Mike


  reply	other threads:[~2022-03-07 16:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 18:00 remove bio_devname Christoph Hellwig
2022-03-04 18:00 ` [PATCH 01/10] block: fix and cleanup bio_check_ro Christoph Hellwig
2022-03-07  3:05   ` Chaitanya Kulkarni
2022-03-04 18:00 ` [PATCH 02/10] block: remove handle_bad_sector Christoph Hellwig
2022-03-07  3:05   ` Chaitanya Kulkarni
2022-03-04 18:00 ` [PATCH 03/10] pktcdvd: remove a pointless debug check in pkt_submit_bio Christoph Hellwig
2022-03-04 18:00 ` [PATCH 04/10] dm-crypt: stop using bio_devname Christoph Hellwig
2022-03-07  3:07   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 05/10] dm-integrity: " Christoph Hellwig
2022-03-07  3:07   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 06/10] md-multipath: " Christoph Hellwig
2022-03-04 19:14   ` Song Liu
2022-03-07  3:07   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 07/10] raid1: " Christoph Hellwig
2022-03-04 19:14   ` Song Liu
2022-03-07  3:06   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 08/10] raid5-ppl: " Christoph Hellwig
2022-03-04 19:14   ` Song Liu
2022-03-04 18:01 ` [PATCH 09/10] ext4: " Christoph Hellwig
2022-03-07  3:08   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 10/10] block: remove bio_devname Christoph Hellwig
2022-03-07  3:06   ` Chaitanya Kulkarni
2022-03-07 11:38 ` Johannes Thumshirn
2022-03-07 13:42 ` Jens Axboe
2022-03-07 16:45   ` Mike Snitzer [this message]
2022-03-07 16:48     ` Christoph Hellwig
2022-03-07 16:56       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiY2wUVIz3NXIjlc@redhat.com \
    --to=snitzer@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).