Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: tytso@mit.edu, jaegeuk@kernel.org, linux-ext4@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH 5/5] ext4: Log error when lookup of encoded dentry fails
Date: Mon, 28 Mar 2022 20:21:50 -0700	[thread overview]
Message-ID: <YkJ7TmwgW5iJswNQ@sol.localdomain> (raw)
In-Reply-To: <20220322030004.148560-6-krisman@collabora.com>

On Mon, Mar 21, 2022 at 11:00:04PM -0400, Gabriel Krisman Bertazi wrote:
> If the volume is in strict mode, ext4_ci_compare can report a broken
> encoding name.  This will not trigger on a bad lookup, which is caught
> earlier, only if the actual disk name is bad.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
>  fs/ext4/namei.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 8520115cd5c2..c321c6fdb4ae 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -1456,6 +1456,9 @@ static bool ext4_match(struct inode *parent,
>  			 * only case where it happens is on a disk
>  			 * corruption or ENOMEM.
>  			 */
> +			if (ret == -EINVAL)
> +				EXT4_ERROR_INODE(parent,
> +						 "Bad encoded file in directory");

Maybe have this say "Bad encoded filename" instead of "Bad encoded file"?

- Eric

      reply	other threads:[~2022-03-29  3:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  2:59 [PATCH 0/5] Clean up the case-insenstive lookup path Gabriel Krisman Bertazi
2022-03-22  3:00 ` [PATCH 1/5] ext4: Match the f2fs ci_compare implementation Gabriel Krisman Bertazi
2022-03-29  2:58   ` Eric Biggers
2022-03-22  3:00 ` [PATCH 2/5] ext4: Simplify the handling of chached insensitive names Gabriel Krisman Bertazi
2022-03-29  3:01   ` Eric Biggers
2022-03-22  3:00 ` [PATCH 3/5] ext4: Implement ci comparison using fscrypt_name Gabriel Krisman Bertazi
2022-03-29  3:08   ` Eric Biggers
2022-03-29 16:11     ` Gabriel Krisman Bertazi
2022-03-31 21:43       ` Eric Biggers
2022-04-04 19:59         ` Gabriel Krisman Bertazi
2022-03-22  3:00 ` [PATCH 4/5] ext4: Simplify hash check on ext4_match Gabriel Krisman Bertazi
2022-03-22  3:00 ` [PATCH 5/5] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-03-29  3:21   ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkJ7TmwgW5iJswNQ@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=kernel@collabora.com \
    --cc=krisman@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox