From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A806C433F5 for ; Tue, 19 Apr 2022 03:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243247AbiDSDVg (ORCPT ); Mon, 18 Apr 2022 23:21:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232721AbiDSDVf (ORCPT ); Mon, 18 Apr 2022 23:21:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF7BF2656A; Mon, 18 Apr 2022 20:18:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A85EB8113A; Tue, 19 Apr 2022 03:18:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0840C385A7; Tue, 19 Apr 2022 03:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650338332; bh=n0VqmNp9Q/CWVDkX0UhhbO6xIAM/hOOSr1ptOPIdeoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T/5WGBYlFp1gL2NKjukwwcRZ+bGenghfSir5xlz/lAF4nZAnqZWutAXfz9wAtVvzi DkuZEd0YZvOg3WoSnFIju4ScMq3nDqvNCcmfDMLtxXoDlMB8i9SinvpdQX0Vrzg4qX aBPaFwK47os5qhDOckOle3ldkuX35gNUN8FsqAHP0je0LnpCfyCZYOS/pKLo2dySIF UjBJRkaTo5RKM3QZEuTQnn6hfX2h0WjPE0JVrZl6cgESLIrhUfHNR4gWPWstl7Y7Js fgow71CxnmQCDuNj+cIbs+Y14N8iKvYHdOxP8wUe+ENpFPs7yXQ0xiQjZxo6gDhwjt 5wz5NjOWC+10Q== Date: Mon, 18 Apr 2022 20:18:50 -0700 From: Eric Biggers To: =?utf-8?B?5bi45Yek5qWg?= Cc: "jaegeuk@kernel.org" , "chao@kernel.org" , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "axboe@kernel.dk" , "linux-block@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Subject: Re: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt Message-ID: References: <20220418063312.63181-1-changfengnan@vivo.com> <20220418063312.63181-2-changfengnan@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 19, 2022 at 03:14:51AM +0000, 常凤楠 wrote: > > Thanks for your explanation, this patchset has too many case to forget to handle... > Back to my first thought, maybe there should have one sysfs node to indicate the > device support inlinecrypt or not ? So user can know it's device not support inlinecrypt > and not for other reasons. > Linux v5.18 has that. See https://git.kernel.org/linus/20f01f1632036660 ("blk-crypto: show crypto capabilities in sysfs"). - Eric