From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com
Subject: Re: [PATCH v4 10/10] f2fs: Move CONFIG_UNICODE defguards into the code flow
Date: Wed, 11 May 2022 21:55:22 -0700 [thread overview]
Message-ID: <YnyTOlV5p498bvPg@sol.localdomain> (raw)
In-Reply-To: <20220511193146.27526-11-krisman@collabora.com>
On Wed, May 11, 2022 at 03:31:46PM -0400, Gabriel Krisman Bertazi wrote:
> @@ -293,10 +294,6 @@ static void f2fs_destroy_casefold_cache(void)
> {
> kmem_cache_destroy(f2fs_cf_name_slab);
> }
> -#else
> -static int __init f2fs_create_casefold_cache(void) { return 0; }
> -static void f2fs_destroy_casefold_cache(void) { }
> -#endif
[...]
> @@ -4611,7 +4608,10 @@ static int __init init_f2fs_fs(void)
> err = f2fs_init_compress_cache();
> if (err)
> goto free_compress_mempool;
> - err = f2fs_create_casefold_cache();
> +
> + if (IS_ENABLED(CONFIG_UNICODE))
> + err = f2fs_create_casefold_cache();
> +
> if (err)
> goto free_compress_cache;
> return 0;
> @@ -4654,7 +4654,9 @@ static int __init init_f2fs_fs(void)
>
> static void __exit exit_f2fs_fs(void)
> {
> - f2fs_destroy_casefold_cache();
> + if (IS_ENABLED(CONFIG_UNICODE))
> + f2fs_destroy_casefold_cache();
> +
I don't think the above two changes are actually an improvement. It's cleaner
to use stub functions to keep the callers simpler, as the original code did.
- Eric
next prev parent reply other threads:[~2022-05-12 4:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 19:31 [PATCH v4 00/10] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 01/10] ext4: Match the f2fs ci_compare implementation Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 02/10] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 03/10] f2fs: " Gabriel Krisman Bertazi
2022-05-12 4:49 ` Eric Biggers
2022-05-11 19:31 ` [PATCH v4 04/10] ext4: Implement ci comparison using unicode_name Gabriel Krisman Bertazi
2022-05-12 5:35 ` Eric Biggers
2022-05-11 19:31 ` [PATCH v4 05/10] ext4: Simplify hash check on ext4_match Gabriel Krisman Bertazi
2022-05-12 5:46 ` Eric Biggers
2022-05-11 19:31 ` [PATCH v4 06/10] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-05-12 5:48 ` Eric Biggers
2022-05-11 19:31 ` [PATCH v4 07/10] ext4: Move ext4_match_ci into libfs Gabriel Krisman Bertazi
2022-05-12 5:24 ` Eric Biggers
2022-05-11 19:31 ` [PATCH v4 08/10] f2fs: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 09/10] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi
2022-05-12 4:59 ` Eric Biggers
2022-05-11 19:31 ` [PATCH v4 10/10] f2fs: " Gabriel Krisman Bertazi
2022-05-12 4:55 ` Eric Biggers [this message]
2022-05-17 19:37 ` [PATCH v4 00/10] Clean up the case-insensitive lookup path Theodore Ts'o
2022-05-17 19:57 ` Gabriel Krisman Bertazi
2022-05-18 0:15 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnyTOlV5p498bvPg@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox