From: "Theodore Ts'o" <tytso@mit.edu>
To: Joe Perches <joe@perches.com>
Cc: Yu Zhe <yuzhe@nfschina.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH] ext4: add KERN_<LEVEL> for printk()
Date: Wed, 25 May 2022 15:25:12 -0400 [thread overview]
Message-ID: <Yo6CmMYr2vBBO+Ks@mit.edu> (raw)
In-Reply-To: <fa2a3a8041b9d814654f0dae4607e1a2f20d333d.camel@perches.com>
On Wed, May 25, 2022 at 08:18:22AM -0700, Joe Perches wrote:
> On Wed, 2022-05-25 at 05:48 -0700, Yu Zhe wrote:
> > printk() should include KERN_<LEVEL> facility level, add them.
>
> NACK.
>
> checkpatch is just a guide.
checkpatch-only patches are something which I will tend to just
ignore. (Even if the changes are correct, which they are not in this
case).
In addition to all of the other reasons why such drive-by checkpatch
patches are frowned upon, I would appreciate it if the code paths that
are changed are actually *tested*, at which point you might have
noticed that your changes werenn't doing the right thing.
(BTW I'll also note that the code involved that is almost never
enabled --- the developer would need to manually insert a "#define
DX_DEBUG" at the beginning of the fs/ext4/namei.c source file for the
code to be enabled. It's only intended to be used by developers who
are doing surgery to the htree code.)
- Ted
prev parent reply other threads:[~2022-05-25 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 12:48 [PATCH] ext4: add KERN_<LEVEL> for printk() Yu Zhe
2022-05-25 15:18 ` David Laight
2022-05-25 15:18 ` Joe Perches
2022-05-25 19:25 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo6CmMYr2vBBO+Ks@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=joe@perches.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).