From: Eric Biggers <ebiggers@kernel.org>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCHv2 1/3] ext4: Move ext4 crypto code to its own file crypto.c
Date: Sat, 14 May 2022 20:33:41 -0700 [thread overview]
Message-ID: <YoB0lYeJv+Cm+C5Y@sol.localdomain> (raw)
In-Reply-To: <4f6b9ff4411ced6591f858119feb025300ecf918.1652539361.git.ritesh.list@gmail.com>
On Sat, May 14, 2022 at 10:52:46PM +0530, Ritesh Harjani wrote:
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index a743b1e3b89e..9100f0ba4a52 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2731,6 +2731,9 @@ extern int ext4_fname_setup_ci_filename(struct inode *dir,
> struct ext4_filename *fname);
> #endif
>
> +/* ext4 encryption related stuff goes here crypto.c */
> +extern const struct fscrypt_operations ext4_cryptops;
> +
> #ifdef CONFIG_FS_ENCRYPTION
Shouldn't the declaration of ext4_cryptops go in the CONFIG_FS_ENCRYPTION block?
Otherwise this patch looks good, thanks.
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2022-05-15 3:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 17:22 [PATCHv2 0/3] ext4/crypto: Move out crypto related ops to crypto.c Ritesh Harjani
2022-05-14 17:22 ` [PATCHv2 1/3] ext4: Move ext4 crypto code to its own file crypto.c Ritesh Harjani
2022-05-15 3:33 ` Eric Biggers [this message]
2022-05-15 4:45 ` Ritesh Harjani
2022-05-14 17:22 ` [PATCHv2 2/3] ext4: Cleanup function defs from ext4.h into crypto.c Ritesh Harjani
2022-05-15 3:40 ` Eric Biggers
2022-05-15 4:49 ` Ritesh Harjani
2022-05-14 17:22 ` [PATCHv2 3/3] ext4: Refactor and move ext4_ioc_get_encryption_pwsalt() Ritesh Harjani
2022-05-15 3:42 ` Eric Biggers
2022-05-15 4:51 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoB0lYeJv+Cm+C5Y@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox