From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com
Subject: Re: [PATCH v6 3/8] libfs: Introduce case-insensitive string comparison helper
Date: Wed, 18 May 2022 20:35:46 -0700 [thread overview]
Message-ID: <YoW7EhTqz0CPOZCL@sol.localdomain> (raw)
In-Reply-To: <20220519014044.508099-4-krisman@collabora.com>
On Wed, May 18, 2022 at 09:40:39PM -0400, Gabriel Krisman Bertazi wrote:
> diff --git a/fs/libfs.c b/fs/libfs.c
> index 974125270a42..c8f40ee35743 100644
> --- a/fs/libfs.c
> +++ b/fs/libfs.c
> @@ -1465,6 +1465,74 @@ static const struct dentry_operations generic_ci_dentry_ops = {
> .d_hash = generic_ci_d_hash,
> .d_compare = generic_ci_d_compare,
> };
> +
> +/**
> + * generic_ci_match() - Match a name (case-insensitively) name with a dirent.
The word "name" is duplicated above.
Otherwise this looks good:
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2022-05-19 3:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 1:40 [PATCH v6 0/8] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 1/8] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 2/8] f2fs: " Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 3/8] libfs: Introduce case-insensitive string comparison helper Gabriel Krisman Bertazi
2022-05-19 3:35 ` Eric Biggers [this message]
2022-05-19 1:40 ` [PATCH v6 4/8] ext4: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-05-19 3:43 ` Eric Biggers
2022-05-19 19:52 ` Gabriel Krisman Bertazi
2022-05-19 20:20 ` Eric Biggers
2022-05-19 1:40 ` [PATCH v6 5/8] f2fs: " Gabriel Krisman Bertazi
2022-05-19 3:43 ` Eric Biggers
2022-05-19 11:32 ` [f2fs-dev] " Chao Yu
2022-05-19 1:40 ` [PATCH v6 6/8] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi
2022-05-19 3:44 ` Eric Biggers
2022-05-19 1:40 ` [PATCH v6 8/8] f2fs: " Gabriel Krisman Bertazi
2022-05-19 11:35 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoW7EhTqz0CPOZCL@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).