From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com
Subject: Re: [PATCH v6 4/8] ext4: Reuse generic_ci_match for ci comparisons
Date: Thu, 19 May 2022 13:20:54 -0700 [thread overview]
Message-ID: <YoampjUJ9Qe060AH@sol.localdomain> (raw)
In-Reply-To: <87h75lnvv9.fsf@collabora.com>
On Thu, May 19, 2022 at 03:52:10PM -0400, Gabriel Krisman Bertazi wrote:
> > It's hard to reason about, though. f2fs does things in a much cleaner way, as
> > I've mentioned before, since it decides which type of match it wants at the
> > beginning, when initializing struct f2fs_filename.
>
> Yes, this is quite confusing. Are these implementation documented
> anywhere?
>
Not very well. The f2fs implementation has some comments, though. E.g. see
struct f2fs_filename and f2fs_setup_filename().
- Eric
next prev parent reply other threads:[~2022-05-19 20:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 1:40 [PATCH v6 0/8] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 1/8] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 2/8] f2fs: " Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 3/8] libfs: Introduce case-insensitive string comparison helper Gabriel Krisman Bertazi
2022-05-19 3:35 ` Eric Biggers
2022-05-19 1:40 ` [PATCH v6 4/8] ext4: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-05-19 3:43 ` Eric Biggers
2022-05-19 19:52 ` Gabriel Krisman Bertazi
2022-05-19 20:20 ` Eric Biggers [this message]
2022-05-19 1:40 ` [PATCH v6 5/8] f2fs: " Gabriel Krisman Bertazi
2022-05-19 3:43 ` Eric Biggers
2022-05-19 11:32 ` [f2fs-dev] " Chao Yu
2022-05-19 1:40 ` [PATCH v6 6/8] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-05-19 1:40 ` [PATCH v6 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi
2022-05-19 3:44 ` Eric Biggers
2022-05-19 1:40 ` [PATCH v6 8/8] f2fs: " Gabriel Krisman Bertazi
2022-05-19 11:35 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoampjUJ9Qe060AH@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox