From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] ext4: update the s_overhead_clusters in the backup sb's when resizing
Date: Thu, 7 Jul 2022 10:35:59 -0400 [thread overview]
Message-ID: <YsbvT2585lxFTq9y@mit.edu> (raw)
In-Reply-To: <68DC6315-7940-48F8-99D9-D26599819EE3@dilger.ca>
On Mon, Jul 04, 2022 at 02:50:47PM -0600, Andreas Dilger wrote:
> > -void ext4_resize_end(struct super_block *sb)
> > +int ext4_resize_end(struct super_block *sb, bool update_backups)
> > {
> > clear_bit_unlock(EXT4_FLAGS_RESIZING, &EXT4_SB(sb)->s_ext4_flags);
> > smp_mb__after_atomic();
> > + if (update_backups)
> > + return ext4_update_overhead(sb, true);
> > + else
> > + return 0;
>
> (style) no need for "else" after return.
Good point, I'll make that adjustment.
- Ted
next prev parent reply other threads:[~2022-07-07 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 4:00 [PATCH 1/2] ext4: update s_overhead_clusters in the superblock during an on-line resize Theodore Ts'o
2022-06-29 4:00 ` [PATCH 2/2] ext4: update the s_overhead_clusters in the backup sb's when resizing Theodore Ts'o
2022-07-04 20:50 ` Andreas Dilger
2022-07-07 14:35 ` Theodore Ts'o [this message]
2022-07-04 20:47 ` [PATCH 1/2] ext4: update s_overhead_clusters in the superblock during an on-line resize Andreas Dilger
2022-07-07 14:32 ` Theodore Ts'o
2022-07-08 3:19 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsbvT2585lxFTq9y@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox