From: "Theodore Ts'o" <tytso@mit.edu>
To: Zorro Lang <zlang@redhat.com>
Cc: Jeremy Bongio <bongiojp@gmail.com>,
linux-ext4@vger.kernel.org, fstests@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH v5] ext4/056: add a check to make sure ext4 uuid ioctls get/set during fsstress.
Date: Wed, 20 Jul 2022 11:30:02 -0400 [thread overview]
Message-ID: <YtgfevC8CnGaZpQ5@mit.edu> (raw)
In-Reply-To: <20220720150636.cvd3ls2mbxbows27@zlang-mailbox>
On Wed, Jul 20, 2022 at 11:06:36PM +0800, Zorro Lang wrote:
> > The kill -9 is needed, because otherwise the test will run for a
> > **very** long time. The reason for it is because of the -n 999999 in
>
> Sure, I mean:
>
> kill -9 $fsstress_pid 2>/dev/null
> wait
>
> Not remove the "kill" line :)
Ah yes, sorry, I misunderstood what you meant.
> > Also, Jeremy, it looks like you haven't updated your xfstests-dev
> > repository in a few weeks. Since you started this project, ext4/056
> > has been assigned, and there has been some new helper programs added
> > which caused patch conflicts in src/Makefile and in .gitignore. They
> > were pretty trivial to fix up the patch conflicts (which I've done in
> > my xfstests-dev tree), but it's best practice to rebase on top of
> > origin/for-next and re-test just to make sure there haven't been some
> > major change in the fstests common scripts that might catch your test
> > out.
>
> Thanks for pointing out that, yes, better to rebase to latest fstests
> for-next branch.
Jeremy, for your convenience, my version of the change which is
rebased on for-next, fixes the merge conflicts and uses ext4/057
instead of ext4/056 can be found here:
https://github.com/tytso/xfstests/commit/330bf72dc67dd39e0fd413ecea78ab18b5405fb9
- Ted
next prev parent reply other threads:[~2022-07-20 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 0:02 [PATCH v5] ext4/056: add a check to make sure ext4 uuid ioctls get/set during fsstress Jeremy Bongio
2022-07-20 10:09 ` Zorro Lang
2022-07-20 11:42 ` Theodore Ts'o
2022-07-20 15:06 ` Zorro Lang
2022-07-20 15:30 ` Theodore Ts'o [this message]
2022-07-20 17:16 ` Jeremy Bongio
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 23:44 Jeremy Bongio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtgfevC8CnGaZpQ5@mit.edu \
--to=tytso@mit.edu \
--cc=bongiojp@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox