From: "Theodore Ts'o" <tytso@mit.edu>
To: Sun Ke <sunke32@huawei.com>
Cc: Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ext4: resize fs after resize_inode without e2fsck
Date: Fri, 22 Jul 2022 07:51:57 -0400 [thread overview]
Message-ID: <YtqPXcFbbrFBr1om@mit.edu> (raw)
In-Reply-To: <b424fd69-aeb4-f749-d09b-5d824454dd94@huawei.com>
On Fri, Jul 22, 2022 at 04:16:26PM +0800, Sun Ke wrote:
>
> 1. The test run fsck automatically, and complain inconsistent，I think it
> need not run fsck.
The check script always run fscks after the test. In order to
suppress the fsck complaint, we'll need to add this after the
resize2fs invocation:
_scratch_unmount
$DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 0" $SCRATCH_DEV \
>>$seqres.full 2>&1
This resets the s_reserved_gdt_blocks field back to zero, so the fsck
doesn't fail. Which is fine, because the point of the test is to see
whether the kernel dereferences a NULL pointer or not.
> 2. It warn missing kernel fix, but the commit had merged.
The way _fixed_by_kernel_commit works is if the test fails (for any
reason), it prints that you MAY be missing the bugfix commit:
> HINT: You _MAY_ be missing kernel fix:
> b55c3cd102a6 ext4: add reserved GDT blocks check
- Ted
next prev parent reply other threads:[~2022-07-22 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:28 [PATCH v3 0/2] two regression tests for ext4 Sun Ke
2022-07-13 9:28 ` [PATCH v3 1/2] ext4: resize fs after resize_inode without e2fsck Sun Ke
2022-07-14 15:46 ` Zorro Lang
2022-07-14 22:00 ` Theodore Ts'o
2022-07-15 18:08 ` Zorro Lang
2022-07-21 3:24 ` Sun Ke
2022-07-22 8:16 ` Sun Ke
2022-07-22 11:51 ` Theodore Ts'o [this message]
2022-07-22 15:11 ` Zorro Lang
2022-07-22 16:36 ` Theodore Ts'o
2022-07-13 9:28 ` [PATCH v3 2/2] ext4: set 256 blocks in a block group then apply io pressure Sun Ke
2022-07-14 16:02 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtqPXcFbbrFBr1om@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sunke32@huawei.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).