From: "Darrick J. Wong" <djwong@kernel.org>
To: Lalith Rajendran <lalithkraj@google.com>
Cc: tytso@mit.edu, dilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Make ext4_lazyinit_thread freezable.
Date: Thu, 18 Aug 2022 17:08:01 -0700 [thread overview]
Message-ID: <Yv7UYfFBmRTKXNc7@magnolia> (raw)
In-Reply-To: <20220818214049.1519544-1-lalithkraj@google.com>
On Thu, Aug 18, 2022 at 09:40:49PM +0000, Lalith Rajendran wrote:
> ext4_lazyinit_thread is not set freezable. Hence when the thread calls
> try_to_freeze it doesn't freeze during suspend and continues to send
> requests to the storage during suspend, resulting in suspend failures.
Maybe we should just make suspend freeze all the filesystems in order?
https://lore.kernel.org/linux-fsdevel/20210417001026.23858-1-mcgrof@kernel.org/
--D
> Signed-off-by: Lalith Rajendran <lalithkraj@google.com>
> ---
> fs/ext4/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9a66abcca1a85..d77e0904a1327 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3767,6 +3767,7 @@ static int ext4_lazyinit_thread(void *arg)
> unsigned long next_wakeup, cur;
>
> BUG_ON(NULL == eli);
> + set_freezable();
>
> cont_thread:
> while (true) {
> --
> 2.31.0
>
next prev parent reply other threads:[~2022-08-19 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:40 [PATCH] ext4: Make ext4_lazyinit_thread freezable Lalith Rajendran
2022-08-19 0:08 ` Darrick J. Wong [this message]
[not found] ` <CANscXK018_PSLPSeTyne7D+KWHa74kyHmdJ8Bxfxyf=5YMPSfw@mail.gmail.com>
2022-08-23 16:03 ` Darrick J. Wong
2022-09-29 14:58 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv7UYfFBmRTKXNc7@magnolia \
--to=djwong@kernel.org \
--cc=dilger.kernel@dilger.ca \
--cc=lalithkraj@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox